Allow the userinfo endpoint to be configured via options. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ful for environments where the url is different such as China
Hanspagh
reviewed
Mar 3, 2020
|
no problem. I'll add some in the morning 👍 |
|
@Hanspagh Allrighty, I've added tests to cover the basics. Let me know what you think. |
Hanspagh
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the userinfo endpoint is hard-coded into the library. However, to make this work in some environments (specifically China), it's necessary to use a different endpoint.
Since options are set at plug compile-time, this also allows runtime configuration of this value by setting a :system tuple to reference an environment variable containing the appropriate setting.
I realize this may be a bit edge-case, but I figure it may be important for projects that aim to deploy in environments with this restriction. (And now that EKS is finally available in China, it may be more important than before to allow this to be set as a runtime config so folks can use the same build)
I hope this can be of use.