Allow newest oauth2 client with security fixes #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oauth2 has a recent possibly backwards incompatible release that makes sure the spec is followed and authorization headers are respected (https://github.com/scrogson/oauth2/blob/master/CHANGELOG.md#v200-2019-07-15) This fixed ueberauth/oauth2#128 hence I think it's important to include. Decided to not require 2.x as that might conflict too hard with other libraries. Also decided to allow minor version bumps as @scrogson seems to be good about semver <3 As ueberauth#66 isn't merged yet I'd like it if this could get in with the release. fixes ueberauth#67
|
Failures look like travis can't find their own erlang packages :( |
nilvon9wo
approved these changes
Aug 21, 2019
|
(I don't have the rights to rerun CI here, hence I pushed an empty commit. I recommend squashing) |
|
This was also failing on master 17 days ago it seems... I'll remove the old elixir versions and add new ones |
yordis
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2 has a recent possibly backwards incompatible release that
makes sure the spec is followed and authorization headers are
respected (https://github.com/scrogson/oauth2/blob/master/CHANGELOG.md#v200-2019-07-15)
This fixed ueberauth/oauth2#128 hence I think it's important to
include.
Decided to not require 2.x as that might conflict too hard
with other libraries. Also decided to allow minor version bumps
as @scrogson seems to be good about semver <3
As #66 isn't merged yet I'd like it if this could get in with the
release.
fixes #67