Set json library on OAuth2 #58
Conversation
|
Hi, any chance to release this soon? I can help if necessary. Currently if you use the most recent versions of ueberauth and ueberauth_google they do not work well togehter. ueberauth will try to use Jason but ueberauth_google will try to use Poison ueberauth 0.6.1 |
|
Ah I'll update right now! |
snewcomer
force-pushed
the
sn/oauth-register-serializer
branch
from
8b45a14 to
6c1b383
Compare
|
@mspanc Updated. I was searching around for quite a while since I knew there was another PR somewhere. Thx for helping dig it out! |
This reverts commit 381bc29.
|
@snewcomer awesome, thanks! @yordis any chance for merging/releasing? |
|
@mspanc I am confused, the PR does not use |
| @@ -27,7 +27,10 @@ defmodule Ueberauth.Strategy.Google.OAuth do | |||
| def client(opts \\ []) do | |||
| config = Application.get_env(:ueberauth, __MODULE__, []) | |||
| opts = @defaults |> Keyword.merge(opts) |> Keyword.merge(config) |> resolve_values() | |||
| json_library = Application.get_env(:ueberauth, :json_library) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
glad somebody looked at my code 😆
|
@yordis are we ready to cut a new release? If so, will you prep the PR to do so? |
|
@doomspork I want to start adding all the for GitHub like such https://github.com/straw-hat-team/straw_hat/tree/master/.github I just need to add the checkbox in Pull Request asking people to add a log to the I will be working on this today for sure. |
|
Could we get a release with this update? v0.8.0 breaks on the hard poison dependency. |
Based on https://github.com/scrogson/oauth2/pull/92/files
ueberauth/ueberauth_twitter#27
ueberauth/ueberauth_twitter#28
ueberauth/ueberauth#88