Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issues #37

Closed
skie opened this issue Jun 27, 2016 · 1 comment
Closed

Build issues #37

skie opened this issue Jun 27, 2016 · 1 comment

Comments

@skie
Copy link
Contributor

skie commented Jun 27, 2016

I'm including "@ng2-dynamic-forms/core": "1.0.0-alpha.8"

On build i have next error.
[default] ./node_modules/@ng2-dynamic-forms/core/src/service/dynamic-form.service.d.ts:2:34
Cannot find module './dynamic-form.model'.

So I checked npm cache package file npm-cache/@ng2-dynamic-forms/core/1.0.0-alpha.8/package.tgz
so inside of it we have src/service/dynamic-form.service.d.ts and it starts from next lines.
import { FormBuilder } from "@angular/forms";
import { DynamicFormModel } from "./dynamic-form.model";

But correct path to dynamic-form.model should be ../model/dynamic-form.model
and for example dynamic-form-control.component.d.ts has it.

Also I have error that already solved by pull request i sent today.
getting error "Type 'void' is not assignable to type 'FormGroup'" for code " this.form = this.dynamicFormService.createFormGroup(this.dynamicFormModel);" where "form: FormGroup;"

@udos86 udos86 added the bug label Jun 27, 2016
udos86 added a commit that referenced this issue Jun 27, 2016
@udos86
Copy link
Owner

udos86 commented Jun 27, 2016

should be fixed in alpha.9 #38

Thanks for your contribution!

@udos86 udos86 closed this as completed Jun 27, 2016
@udos86 udos86 added the core label Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants