Tests for loops over arrays (#982)

uber · Jun 19, 2024 · 4f6f21e · 4f6f21e
1 parent 8593fe2
commit 4f6f21e
Showing 1 changed file with 46 additions and 0 deletions.
diff --git a/nullaway/src/test/java/com/uber/nullaway/jspecify/ArrayTests.java b/nullaway/src/test/java/com/uber/nullaway/jspecify/ArrayTests.java
@@ -3,6 +3,7 @@
 import com.google.errorprone.CompilationTestHelper;
 import com.uber.nullaway.NullAwayTestsBase;
 import java.util.Arrays;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class ArrayTests extends NullAwayTestsBase {
@@ -470,6 +471,51 @@ public void localVariableIndexArray() {
         .doTest();
   }
 
+  @Test
+  public void loopVariableIndex() {
+    makeHelper()
+        .addSourceLines(
+            "Test.java",
+            "package com.uber;",
+            "import org.jspecify.annotations.Nullable;",
+            "class Test {",
+            "  static @Nullable String[] fizz = {\"1\"};",
+            "  static void foo() {",
+            "    for (int i = 0; i < fizz.length; i++) {",
+            "      if (fizz[i] != null) {",
+            "        fizz[i].toString();",
+            "      }",
+            "    }",
+            "  }",
+            "}")
+        .doTest();
+  }
+
+  @Test
+  @Ignore("for-each handling needs to be fixed; see https://github.com/uber/NullAway/issues/983")
+  public void forEachLoop() {
+    makeHelper()
+        .addSourceLines(
+            "Test.java",
+            "package com.uber;",
+            "import org.jspecify.annotations.Nullable;",
+            "class Test {",
+            "  static @Nullable String[] fizz = {\"1\"};",
+            "  static void foo() {",
+            "    for (String s : fizz) {",
+            "      if (s != null) {",
+            "        s.toString();",
+            "      }",
+            "    }",
+            "    for (String s : fizz) {",
+            "      // BUG: Diagnostic contains: dereferenced expression s is @Nullable",
+            "      s.toString();",
+            "    }",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void methodInvocationIndexArray() {
     makeHelper()