go-source tag is no longer necessary

[abhinav]

The package template generates a go-source tag along with the go-import tag.

sally/templates/package.html

Lines 4 to 5 in 434fc43

	<meta name="go-import" content="{{ .CanonicalURL }} git https://{{ .Repo }}">
	<meta name="go-source" content="{{ .CanonicalURL }} https://{{ .Repo }} https://{{ .Repo }}/tree/{{ .Branch }}{/dir} https://{{ .Repo }}/tree/{{ .Branch }}{/dir}/{file}#L{line}">

The go-import tag is used by the go CLI to find the source code. Details at https://go.dev/ref/mod#vcs-find.

However, go-source is a leftover from pre-Go-module days, in service of godoc.org: https://github.com/golang/gddo/wiki/Source-Code-Links
This is no longer necessary -- pkg.go.dev serves documentation and module-version-aware source links directly.

[sywhang]

internal ref: GO-2001

[SoulPancake]

Is this good to be removed then? @abhinav @sywhang

[abhinav]

@SoulPancake Yes, based on my reading of the Go Modules docs and the godoc.org docs, I believe this should be safe to remove. I'll defer to @sywhang and other maintainers on whether the change is welcome.

[sywhang]

@SoulPancake yup! We welcome contributions that'll remove it.

[hacdias]

Correct me if I'm wrong, but this seems like a regression. pkg.go.dev still uses go-source for unknown VCS systems: https://pkg.go.dev/about#source-links - right now, Sally only supports GitHub, but it'd be great if it were more generic.

[abhinav]

@hacdias Yeah, that's right. Thanks for pointing this out. We'll revert the change.