Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic filters not working when "Show your windows and tabs from last time" (Firefox) until page is reloaded #72

Closed
7 of 8 tasks
ranolfi opened this issue Jun 13, 2018 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@ranolfi
Copy link

ranolfi commented Jun 13, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

I have "Show your windows and tabs from last time" configured for the When Firefox starts setting.

When I close the browser, when reopening, it'll of course restore my previous windows and tabs, but cosmetic filtering won't work until reloading the page.

(I don't know about other filtering, only cosmetic.)

A specific URL where the issue occurs

https://stackoverflow.com/q/5508110/3258851
https://www.youtube.com/watch?v=dQw4w9WgXcQ

Steps to Reproduce

  1. Have Firefox configured to restore windows and tabs from previous session upon launching
  2. configure ###hot-network-questions to your custom filter rules, if testing with Stack Overflow; or www.youtube.com###related if testing with Youtube (or any custom rule for any other website, really)
  3. open said website and verify that the filter works
  4. quit Firefox and reopen it

Expected behavior:

Page should be reopened in the exact state it was upon closing - i.e. with cosmetic filtering applied.

Actual behavior:

Page is reopened as if uBlock Origin is disabled.

Note: this is true even if the page is not the active tab at the moment of closing the browser

Your environment

  • uBlock Origin version: 1.16.8
  • Browser Name and version: Mozilla Firefox 60.0.2
  • Operating System and version: Arch Linux with Cinnamon 3.8.4 and kernel 4.16.13.
@ranolfi
Copy link
Author

ranolfi commented Jun 14, 2018

gorhill/uBlock#3270

gorhill/uBlock#1327

Solved with advanced setting suspendTabsUntilReady.

Closing.

@ranolfi ranolfi closed this as completed Jun 14, 2018
@uBlock-user uBlock-user added the duplicate This issue or pull request already exists label Jun 14, 2018
@uBlock-user
Copy link
Contributor

Duplicate of gorhill/uBlock#1327

@uBlock-user uBlock-user marked this as a duplicate of gorhill/uBlock#1327 Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants