Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element picker not working on support.mozilla.org #512

Closed
8 tasks done
ExDomino opened this issue Apr 6, 2019 · 7 comments
Closed
8 tasks done

Element picker not working on support.mozilla.org #512

ExDomino opened this issue Apr 6, 2019 · 7 comments
Labels
invalid not a uBlock issue

Comments

@ExDomino
Copy link

ExDomino commented Apr 6, 2019

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

The element picker doesn't work on Mozilla's support website.

A specific URL where the issue occurs

On some rare websites, but the only one I have in head at this moment is the Mozilla's support website.
https://support.mozilla.org/
You can reproduce the bug on every page of this domain as well.

Steps to Reproduce

  1. Go to "https://support.mozilla.org/".
  2. Left click to the "uBlock Origin" icon to open its menu.
  3. Click to the element picker icon in order to hide, for example, the black sticky header.
  4. See that you are not entered in picker mode. The element zapper is not working either.

Expected behavior:

The element picker should works on this site as it works everywhere else.

Actual behavior:

The element picker doesn't work at all on this site, nor the element zapper.

Your environment

  • uBlock Origin version: 1.18.16
  • Browser Name and version: Firefox 66.0.2 (64 bits)
  • Operating System and version: Issue occuring on both Windows 7 and 10 (both in 64 bits)
@gwarser
Copy link

gwarser commented Apr 6, 2019

@gwarser gwarser closed this as completed Apr 6, 2019
@uBlock-user uBlock-user added the invalid not a uBlock issue label Apr 6, 2019
@ExDomino
Copy link
Author

ExDomino commented Apr 7, 2019

Sorry if my bug report is "invalid" but an non effective button without any error message can be assimiled as a bug. Maybe you can gray out the button and say in the tooltip why you disabled it.

@gorhill
Copy link
Member

gorhill commented Apr 7, 2019

uBO doesn't even know it is disabled, the browser bypasses uBO without telling the extension it does so.

@ExDomino
Copy link
Author

ExDomino commented Apr 7, 2019

A solution for that case would be trying to read the « extensions.webextensions.restrictedDomains » and gray out these buttons on these pages, provided that reading a config value is allowed for addons.

@gorhill
Copy link
Member

gorhill commented Apr 7, 2019

trying to read the « extensions.webextensions.restrictedDomains »

Not possible.

If you think you know how to solve this, a pull request is welcome, otherwise this is going to be an endless thread asking someone else to spend time/effort on your ideas of what to do.

@gorhill
Copy link
Member

gorhill commented Apr 7, 2019

The browser is best placed to know when it bypasses extensions, so it makes sense to file an issue at https://bugzilla.mozilla.org/home to ask that they provide a hint when extensions are bypassed, that would be one solution for all extensions, rather than asking each extensions to deal with this.

@uBlock-user
Copy link
Contributor

Sorry if my bug report is "invalid" but an non effective button without any error message can be assimiled as a bug. Maybe you can gray out the button and say in the tooltip why you disabled it.

This is by-design extension behaviour, so either the use the hack listed in Privileged-Pages or file an issue on bugzilla.

@uBlockOrigin uBlockOrigin locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

4 participants