Handle multiple windows

[aphilas]

I have two monitors. Clicking the uBOL extension button on Window 2 brings up the setting for the active tab of the window on the primary monitor rather than the window I'm on (the secondary monitor).

Example:

window 1, monitor 1   window 2, monitor 2

+-------------------+ +--------------------+
| github.com        | | wikifeet.com       |
|                   | |       +----------+ |
|                   | |       |basic     | |
|                   | |       |   x      | |
|                   | |       |xxxxxxxxxx| |
|                   | |       |   x      | |
|                   | |       |github.com| |
|                   | |       +----------+ |
|                   | |                    |
|                   | |                    |
+-------------------+ +--------------------+

Linux 5.4.0-132-generic | ~18.04.1-Ubuntu
Chrome Version 107.0.5304.110 (Official Build) (64-bit)
uBlock Origin Lite 0.1.22.11165

[gorhill]

I don't have two monitors so I can't test if the change fixes this. You will have to report back if it's fixed in the next release.

[aphilas]

I have disconnected the second monitor and the issue still persists (with two windows). Am I missing something? Does it work with multiple windows on your computer?

…

On Fri, Nov 25, 2022 at 5:24 PM Raymond Hill ***@***.***> wrote: I don't have two monitors so I can't test if the change fixes this. You will have to report back if it's fixed in the next release. — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHPTR2R5WSPU2NCFERHHCGTWKDDYTANCNFSM6AAAAAASLAJYP4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[aphilas]

I have seen the referenced commit. Appears to fix the issue.

I presume await browser.tabs.query({ active: true, currentWindow: true }) would also work, no?

I have also installed the dev version and will await the release with the fix and report back here.

---

Edit:

Dev build seems to work alright! I'll go ahead and close this issue.

[gorhill]

I presume await browser.tabs.query({ active: true, currentWindow: true }) would also work, no?

Thanks for pointing this out, I will use this instead.