Regex checked only if ISO date was present in the string, it should c…

…heck if the entire string is ISO Date
typestack · Nov 4, 2018 · 5012464 · 5012464
1 parent 064458a
commit 5012464
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/validation/Validator.ts b/src/validation/Validator.ts
@@ -341,7 +341,7 @@ export class Validator {
      * Checks if a given value is a ISOString date.
      */
     isDateString(value: any): boolean {
-        const regex = /\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:Z|\+[0-2]\d(?:\:[0-5]\d)?)?/g;
+        const regex = /^\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:Z|\+[0-2]\d(?:\:[0-5]\d)?)?$/g;
         return this.isString(value) && regex.test(value);
     }
 

diff --git a/test/functional/validation-functions-and-decorators.spec.ts b/test/functional/validation-functions-and-decorators.spec.ts
@@ -619,7 +619,9 @@ describe("IsDateString", function() {
         2,
         null,
         undefined,
-        "text"
+        "text",
+        "text2018-01-04T08:15:30+04",
+        "2018-01-04T08:15:30Ztext",
     ];
 
     class MyClass {