Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@type/ember bug] handlebars declare conflict #566

Closed
2 tasks done
xg-wang opened this issue Feb 11, 2019 · 3 comments
Closed
2 tasks done

[@type/ember bug] handlebars declare conflict #566

xg-wang opened this issue Feb 11, 2019 · 3 comments
Assignees
Labels

Comments

@xg-wang
Copy link

xg-wang commented Feb 11, 2019

Which package(s) does this problem pertain to?

  • @types/ember
  • @types/ember__string

Since [email protected] the types field is added in its package.json, so I'm hitting this issue after a yarn upgrade:

node_modules/handlebars/lib/handlebars.d.ts:14:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: Template, escapeExpression, logger, templates, helpers, partials, decorators, SafeString, Visitor, HandlebarsTemplateDelegate, RuntimeOptions, Utils, Handlebars

14 declare namespace Handlebars {
   ~~~~~~~

  node_modules/@types/handlebars/index.d.ts:7:1
    7 declare namespace Handlebars {
      ~~~~~~~
    Conflicts are in this file.

node_modules/@types/handlebars/index.d.ts:7:1 - error TS6200: Definitions of the following identifiers conflict with those in another file: Template, escapeExpression, logger, templates, helpers, partials, decorators, SafeString, Visitor, HandlebarsTemplateDelegate, RuntimeOptions, Utils, Handlebars

7 declare namespace Handlebars {
  ~~~~~~~

  node_modules/handlebars/lib/handlebars.d.ts:14:1
    14 declare namespace Handlebars {
       ~~~~~~~
    Conflicts are in this file.

node_modules/@types/handlebars/index.d.ts:35:9 - error TS2374: Duplicate string index signature.

35         [key: string]: HelperDelegate;
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@types/handlebars/index.d.ts:155:5 - error TS2374: Duplicate string index signature.

155     [index: string]: HandlebarsTemplateDelegate;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@xg-wang
Copy link
Author

xg-wang commented Feb 11, 2019

[I] ➜ yarn why @types/handlebars
yarn why v1.10.1
[1/4] 🤔  Why do we have the module "@types/handlebars"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "@types/[email protected]"
info Reasons this module exists
   - "@types#ember" depends on it
   - Hoisted from "@types#ember#@types#handlebars"
   ]- Hoisted from "@types#ember#@types#ember__string#@types#handlebars"

@mike-north
Copy link
Contributor

I believe this will be fixed by DefinitelyTyped/DefinitelyTyped#32897

whose tests will start passing w/ the next nightly TS release, now that microsoft/TypeScript#29787 has been merged

@chriskrycho
Copy link
Member

Resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants