Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript types #1

Closed
vilterp opened this issue Oct 3, 2017 · 3 comments
Closed

Add typescript types #1

vilterp opened this issue Oct 3, 2017 · 3 comments

Comments

@vilterp
Copy link

vilterp commented Oct 3, 2017

I'm adding a declaration to the DefinitelyTyped repo here, which will allow the library to be used in a typechecked fashion, but evidently it's preferred if they're checked in to the package itself. I don't quite have time to do this; letting you know in case you do. Thanks for a useful library!

There are some instructions here.

Used in CockroachDB; checked type declarations into our repo but would prefer to have them elsewhere.

@tylerlong
Copy link
Contributor

I don't use TypeScript myself so I am afraid that I am unable to do it. Let's wait for a community PR :)

@vilterp
Copy link
Author

vilterp commented Oct 6, 2017

Fair enough — the DefinitelyTyped PR got merged, so for the time being TypeScript users can npm install @types/dagre-layout.

@tylerlong
Copy link
Contributor

Close it for now. Feel free to create a new issue if you have new ideas/suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants