Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login window when resolution changes #187

Closed
twocanoes opened this issue Mar 7, 2024 · 15 comments
Closed

Update login window when resolution changes #187

twocanoes opened this issue Mar 7, 2024 · 15 comments
Assignees
Milestone

Comments

@twocanoes
Copy link
Owner

Seeing an issue with window dimensions on macOS 14.4. Upon boot, dimensions are wrong. If I kill loginwindow they are correct. Reboot and dimensions are wrong again. A guess is that Apple is changing resolution so may need to subscribe to NSScreen changes. This is on M1 Air. (edited)

@twocanoes
Copy link
Owner Author

I thnk this is fixed. can't replicate in current bulid.

@kcrawford
Copy link

This issue still exists in beta 5.0 (7087)

Note that it only presents on boot of Apple Silicon with FileVault not yet enabled.

@twocanoes twocanoes added this to the XCreds 5 milestone Jun 28, 2024
@twocanoes twocanoes self-assigned this Jun 28, 2024
@twocanoes twocanoes reopened this Jul 15, 2024
@davelebbing
Copy link
Collaborator

@kcrawford I did a test on an M1 MacBook Air reset to factory settings and running XCreds 5.0 build 7087. I could not replicate any issue with window dimensions upon system boot. Would you have a screenshot or something showing the window dimensions issue you are seeing?

@kcrawford
Copy link

kcrawford commented Jul 15, 2024 via email

@davelebbing
Copy link
Collaborator

@kcrawford, I was able to replicate this now. @twocanoes, the attached screenshots show the login window dimensions changing when set at 800x800 and then clicking the switch login window button. The login window initially renders all the way from the top of the screen to the bottom, then after switching login window and switching back it renders shorter and narrower with space noticeable above and below.
LWScreenShot 2024-07-16 at 10 50 56 AM
LWScreenShot 2024-07-16 at 10 50 57 AM
LWScreenShot 2024-07-16 at 10 51 29 AM
Screenshot 2024-07-16 at 10 52 51 AM
Screenshot 2024-07-16 at 10 52 55 AM

@twocanoes
Copy link
Owner Author

OK, I think i got it now. Please verify it works then close or assign back to me.

@kcrawford
Copy link

Thanks! Can you create a release for me to test.

@twocanoes
Copy link
Owner Author

it is in the latest build.

tim

@kcrawford
Copy link

kcrawford commented Aug 7, 2024 via email

@kcrawford
Copy link

kcrawford commented Aug 7, 2024 via email

@davisbr1
Copy link

davisbr1 commented Aug 7, 2024

I'm seeing a similar issue to this as well. I'm running macOS 14.6 on a M2 Mac mini, filevault not enabled, with a Dell external monitor attached. Screen after boot is the first screenshot, the second picture shows after clicking Switch Login Window twice, and the 3rd picture shows how it looks after clicking Switch Login Window for a second round.
XCreds1
XCreds2
XCreds3

@twocanoes
Copy link
Owner Author

@davisbr1 what build? I did a bunch of work on fixing that last night, so please try the last build.

@davisbr1
Copy link

davisbr1 commented Aug 7, 2024

5.0.7133

@twocanoes
Copy link
Owner Author

please test in build 7141 or later.

@davisbr1
Copy link

Issue is resolved for me on build 7146! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants