Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store exceptions #49

Closed
dentarg opened this issue Oct 23, 2015 · 4 comments
Closed

Store exceptions #49

dentarg opened this issue Oct 23, 2015 · 4 comments

Comments

@dentarg
Copy link
Collaborator

dentarg commented Oct 23, 2015

I think it could be a good idea to store the exceptions that Twingly::URL swallow. It might be useful to know why a particular wasn't valid, as the list of exceptions we rescue will likely grow.

We could expose .exceptions, just like MetaInspector does: https://github.com/jaimeiniesta/metainspector#exception-handling (we already have the ok? equivalent in valid?)

WDYT @twingly/dev?

Somewhat related to #44, #31, #25

@jage
Copy link
Contributor

jage commented Oct 26, 2015

Sure, this would be a very good feature to have if/when we capture all unhandled exceptions. #31 should probably be solved before or at the same time as this.

@dentarg dentarg removed the question label Oct 29, 2015
@dentarg
Copy link
Collaborator Author

dentarg commented Nov 15, 2015

Just want to note that MetaInspector might remove their exception log: jaimeiniesta/metainspector#154

@dentarg dentarg added this to the Close without action milestone Nov 5, 2016
@dentarg
Copy link
Collaborator Author

dentarg commented Nov 6, 2016

I don't think this is worth the effort. Close as wontfix?

@walro
Copy link
Contributor

walro commented Nov 6, 2016

Works for me.

@dentarg dentarg added the wontfix label Nov 6, 2016
@dentarg dentarg closed this as completed Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants