-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize method can't handle URLs with punycoded TLD #28
Comments
It was pointed out that the TLD is really funky here. |
Strange, xn--p1ai (or рф) is in the public suffix list I tested too, with public_suffix 1.5.1, got the same as above. Don't really know of public_suffix work, if that above should be enough to support xn--p1ai or if they are missing something. Could it be an encoding issue? |
Yeah, to get it working (with public-suffix) we need to go from punycode back to utf-8: irb(main):005:0> PublicSuffix.valid?("xn--80aesdcplhhhb0k.xn--p1ai")
=> false
irb(main):006:0> PublicSuffix.valid?("domain.рф")
=> true Public suffix won't add support for it: weppos/publicsuffix-ruby#24 We could use https://github.com/mmriis/simpleidn (I found other, even less maintained, alternatives too) to do this ourselves. |
We should analyze our data and how many punycode TLDs do we have. |
Page loads fine in Chrome though, whois works fine too.
The text was updated successfully, but these errors were encountered: