Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwilioHttpClient does not support timeout in constructor #460

Closed
joninvski opened this issue Apr 15, 2019 · 3 comments · Fixed by #485
Closed

TwilioHttpClient does not support timeout in constructor #460

joninvski opened this issue Apr 15, 2019 · 3 comments · Fixed by #485
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@joninvski
Copy link

joninvski commented Apr 15, 2019 •
edited
Loading

Version: 6.26.1

Feature Request

The TwilioHttpClient constructor does not support a timeout parameter. This makes it more troublesome for clients to configure a maximum time requests should wait for replies from twilio.

Does it seem ok to add a timeout parameter (defaults to None as it is working today) to the TwilioHttpClient. In ruby we have this option: https://github.com/twilio/twilio-ruby/blob/master/lib/twilio-ruby/http/http_client.rb#L11

If i have your 👍 i'll work on this and open the PR.

Note: This is the PR that added the functionality to the ruby library: twilio/twilio-ruby#339
@eshanholtz eshanholtz added difficulty: unknown or n/a fix is unknown in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty and removed difficulty: unknown or n/a fix is unknown in difficulty labels Sep 13, 2019
@eshanholtz
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@childish-sambino
Copy link
Contributor

@joninvski Sure, if you can submit a PR we'll take a look!

@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Sep 25, 2019
@Kerl1310 Kerl1310 mentioned this issue Oct 15, 2019
Merged
1 task
@Kerl1310
Copy link
Contributor

Kerl1310 commented Oct 15, 2019 •
edited
Loading

Opened #485 to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding timeout to TwilioHttpClient constructor Kerl1310/twilio-python
4 participants
@joninvski @Kerl1310 @eshanholtz @childish-sambino