Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-handler): add warning for optional context vars #317

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

dkundel
Copy link
Member

@dkundel dkundel commented Jul 14, 2021

I'm going with Option 2 from #304 here as it got the most upvotes. We'll release it as @twilio/runtime-handler/1.1.2 but in theory Option 2 is compatible with any version of the runtime-handler.

The warning looks the following:
Screen Shot 2021-07-13 at 17 53 21

re #304

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link
Contributor

@philnash philnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who doesn't love a regex over a a stack trace from an error that doesn't actually get thrown!

@dkundel dkundel merged commit 47051de into main Jul 19, 2021
@dkundel dkundel deleted the features/handler-1.1.2 branch July 19, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants