Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy): adds runtime as a flag to the deploy command #218

Merged
merged 4 commits into from
Apr 15, 2021

Conversation

philnash
Copy link
Contributor

Users can currently choose between node10 and node12 as a runtime (although that choice will go away).

This adds a runtime flag to twilio-run's deploy command to choose between node10 and node12, and support for the runtime option in serverless-api.

I don't think I need to add anything to the severless-plugin, do I?

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@philnash philnash requested a review from dkundel February 15, 2021 07:25
This way we don't need to upgrade the plugin when a new runtime is available, or when one is removed.
@philnash philnash added this to the Post v3 milestone Feb 25, 2021
@philnash
Copy link
Contributor Author

This has been backported to twilio-run on the twilio-run-v2 branch and to serverless-api on the v4 branch.

@philnash philnash modified the milestones: Post v3, v3 Feb 25, 2021
@dkundel dkundel merged commit 789ec02 into main Apr 15, 2021
@dkundel dkundel deleted the runtime-update branch April 15, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants