Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities with an index greater than 2047 corrupt the client's heap if sent over the network #191

Closed
SamVanheer opened this issue Feb 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@SamVanheer
Copy link
Collaborator

If an entity with an index greater than 2047 is sent over the network the client's heap may be corrupted because the index is sent using only 11 bits (2^11 == 2048). Essentially the index is sent over as index % 2048. If the entity in the resulting index is not in use then the heap can be corrupted due to invalid access.

To prevent this the server should refuse to send entities with an index that would cause such a problem.

@SamVanheer SamVanheer added the bug Something isn't working label Feb 4, 2023
@SamVanheer SamVanheer self-assigned this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant