From 798ec961506b96c1af883f877f6a650bf6cd6ee7 Mon Sep 17 00:00:00 2001 From: Andreas Herrmann Date: Mon, 27 May 2019 14:56:37 +0200 Subject: [PATCH] --test_tag_filters -dont_test_on_darwin in run-tests --- tests/RunTests.hs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/RunTests.hs b/tests/RunTests.hs index 6538e3b09..32ade57d3 100644 --- a/tests/RunTests.hs +++ b/tests/RunTests.hs @@ -6,6 +6,7 @@ import Data.Foldable (for_) import Data.List (isInfixOf, sort) import System.Exit (ExitCode(..)) +import System.Info (os) import qualified System.Process as Process import Test.Hspec.Core.Spec (SpecM) @@ -37,7 +38,13 @@ main = hspec $ do ]) it "bazel test prof" $ do - assertSuccess (bazel ["test", "-c", "dbg", "//...", "--build_tests_only", "--test_tag_filters", "-requires_dynamic"]) + -- In .circleci/config.yml we specify --test_tag_filters + -- -dont_test_on_darwin. However, specifiying --test_tag_filters + -- -requires_dynamic here alone would override that filter. So, + -- we have to duplicate that filter here. + let tagFilter | os == "darwin" = "-dont_test_on_darwin,-requires_dynamic" + | otherwise = "-requires_dynamic" + assertSuccess (bazel ["test", "-c", "dbg", "//...", "--build_tests_only", "--test_tag_filters", tagFilter]) describe "repl" $ do it "for libraries" $ do