Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should validation use box-shadow? #24389

Closed
alecpl opened this issue Oct 16, 2017 · 2 comments
Closed

Should validation use box-shadow? #24389

alecpl opened this issue Oct 16, 2017 · 2 comments
Assignees
@mdo
Labels
css has-pr v4

Comments

@alecpl
Copy link
Contributor

alecpl commented Oct 16, 2017

.form-control inputs when focused do not use box-shadow, so why inputs with .is-invalid/.is-valid do? I propose to get rid of the box-shadow. Or maybe there are some variables that need to be used/set properly?

No test case. All you need is to visit https://getbootstrap.com/docs/4.0/components/forms.
@mdo
Copy link
Member

mdo commented Oct 17, 2017

Yes it should, and I should re-enable the focus shadow on inputs by default.

@alecpl
Copy link
Contributor Author

alecpl commented Oct 18, 2017

I understand you want to see focus/validation state at the same time. I'm fine with this as long as it's consistent. Thanks.

@mdo mdo added the has-pr label Oct 19, 2017
@mdo mdo mentioned this issue Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdo mdo

Labels
css has-pr v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdo @alecpl @Johann-S