Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint for unused SCSS variables #18623

Closed
cvrebert opened this issue Dec 21, 2015 · 1 comment
Closed

Lint for unused SCSS variables #18623

cvrebert opened this issue Dec 21, 2015 · 1 comment

Comments

@cvrebert
Copy link
Collaborator

See:

v4 currently (as of d756e12) has several unused variables:

$enable-gradients
$font-family-serif
$font-size-xs
$line-height-computed
$nav-link-hover-bg
$nav-pills-active-link-hover-bg
$nav-pills-active-link-hover-color
$nav-tabs-justified-active-link-border-color
$nav-tabs-justified-link-border-color
$navbar-dark-disabled-color
$navbar-light-disabled-color
$pre-bg
$pre-border-color
$progress-bar-bg
$progress-border-radius

Also, we'll need some sort of exemption system (e.g. magic comments) for variables which we don't use out of the box but are exposed for the benefit of downstream users (e.g. the many color palette vars in #18462).

@mdo
Copy link
Member

mdo commented Jan 6, 2016

Updated the list above to remove the pager variables—done in fe40de1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants