Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binding the appservice listener to an existing express app. #191

Closed
Half-Shot opened this issue Jan 4, 2022 · 4 comments
Closed

Support binding the appservice listener to an existing express app. #191

Half-Shot opened this issue Jan 4, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Half-Shot
Copy link
Contributor

Ideally, I'd like for the bot-sdk to export a Router object, which I could then bind via expressApp.use to my existing express instance. The need is for hookshot to support several different listeners on the same port.
@turt2live
Copy link
Owner

There's quite a lot of middleware which goes into running an appservice, and express is not guaranteed. The app instance is exposed by the bot-sdk as a short term solution.

@Half-Shot
Copy link
Contributor Author

Okay, alternatively I need a way to pass in HTTP requests from my code into the appservice class somehow. Because of the same middleware, it's not easy to bind to the existing app instance.

@turt2live turt2live added the enhancement New feature or request label May 30, 2022
@AndrewFerr
Copy link
Contributor

Looks like this was fixed by #349?

@turt2live
Copy link
Owner

It was already technically supported, but buggy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @Half-Shot @AndrewFerr