Validate table Name property matches key in plugin's TableMap. Closes #355

Author: kaidaguerre

cache/query_cache.go

@@ -304,6 +304,8 @@ func (c *QueryCache) getKeyColumnsForTable(table string) map[string]*proto.KeyCo
 		for _, k := range append(tableSchema.ListCallKeyColumnList, tableSchema.GetCallKeyColumnList...) {
 			res[k.Name] = k
 		}
+	} else {
+		log.Printf("[WARN] getKeyColumnsForTable found NO SCHEMA FOR %s", table)
 	}
 	return res
 }

plugin/plugin.go

@@ -416,6 +416,9 @@ func (p *Plugin) ensureCache() error {
 }
 
 func (p *Plugin) buildSchema() (map[string]*proto.TableSchema, error) {
+	log.Printf("[TRACE] buildSchema")
+	defer log.Printf("[TRACE] buildSchema complete")
+
 	// the connection property must be set already
 	if p.Connection == nil {
 		return nil, fmt.Errorf("plugin.GetSchema called before setting connection config")

plugin/plugin_validate.go

@@ -29,6 +29,20 @@ func (p *Plugin) Validate() string {
 	log.Printf("[TRACE] validate DefaultIgnoreConfig")
 	validationErrors = append(validationErrors, p.DefaultIgnoreConfig.Validate(nil)...)
 
+	log.Printf("[TRACE] validate table names")
+	validationErrors = append(validationErrors, p.validateTableNames()...)
+
 	log.Printf("[TRACE] plugin has %d validation errors", len(validationErrors))
 	return strings.Join(validationErrors, "\n")
 }
+
+// validate that table names are consistent with their key in the table map
+func (p *Plugin) validateTableNames() []string {
+	var validationErrors []string
+	for tableName, table := range p.TableMap {
+		if table.Name != tableName {
+			validationErrors = append(validationErrors, fmt.Sprintf("table '%s' has inconsistent Name property: '%s'", tableName, table.Name))
+		}
+	}
+	return validationErrors
+}