Improve logging

Author: japborst

github/table_github_commit.go

@@ -154,7 +154,6 @@ func tableGitHubCommitGet(ctx context.Context, d *plugin.QueryData, h *plugin.Hy
 		var owner, repo string
 		var sha string
 
-		logger := plugin.Logger(ctx)
 		quals := d.KeyColumnQuals
 
 		if h.Item != nil {
@@ -175,7 +174,7 @@ func tableGitHubCommitGet(ctx context.Context, d *plugin.QueryData, h *plugin.Hy
 		}
 
 		owner, repo = parseRepoFullName(fullName)
-		logger.Trace("tableGitHubCommitGet", "owner", owner, "repo", repo, "sha", sha)
+		plugin.Logger(ctx).Trace("tableGitHubCommitGet", "owner", owner, "repo", repo, "sha", sha)
 		detail, _, err := client.Repositories.GetCommit(ctx, owner, repo, sha, opts)
 
 		return detail, err

github/table_github_pull_request.go

@@ -86,12 +86,11 @@ func tableGitHubPullRequest() *plugin.Table {
 //// LIST FUNCTION
 
 func tableGitHubPullRequestList(ctx context.Context, d *plugin.QueryData, h *plugin.HydrateData) (interface{}, error) {
-	logger := plugin.Logger(ctx)
 	quals := d.KeyColumnQuals
 
 	fullName := quals["repository_full_name"].GetStringValue()
 	owner, repo := parseRepoFullName(fullName)
-	logger.Trace("tableGitHubPullRequestList", "owner", owner, "repo", repo)
+	plugin.Logger(ctx).Trace("tableGitHubPullRequestList", "owner", owner, "repo", repo)
 
 	opt := &github.PullRequestListOptions{
 		ListOptions: github.ListOptions{PerPage: 100},

github/utils.go

@@ -80,6 +80,7 @@ func getGitHubItem(ctx context.Context, d *plugin.QueryData, h *plugin.HydrateDa
 	getDetails := func(ctx context.Context, d *plugin.QueryData, h *plugin.HydrateData) (interface{}, error) {
 		client := connect(ctx, d)
 
+		plugin.Logger(ctx).Trace("Hydrating", "table", d.Table.Name, "quals", d.KeyColumnQuals, "fetchType", d.FetchType)
 		return getDetailsFunc(ctx, d, h, client)
 	}