From a29fe8a8841c16cbcc9eca8439a3bab733c66dae Mon Sep 17 00:00:00 2001
From: Lalit Bhardwaj <37527306+LalitTurbot@users.noreply.github.com>
Date: Mon, 22 Feb 2021 22:41:33 +0530
Subject: [PATCH] Fix: labels field for gcp_storage_bucket table. #115 (#120)

---
 gcp-test/tests/gcp_storage_bucket/test-turbot-expected.json | 3 +++
 gcp-test/tests/gcp_storage_bucket/test-turbot-query.sql     | 2 +-
 gcp/table_gcp_storage_bucket.go                             | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gcp-test/tests/gcp_storage_bucket/test-turbot-expected.json b/gcp-test/tests/gcp_storage_bucket/test-turbot-expected.json
index 988bcef6..588a09fa 100644
--- a/gcp-test/tests/gcp_storage_bucket/test-turbot-expected.json
+++ b/gcp-test/tests/gcp_storage_bucket/test-turbot-expected.json
@@ -3,6 +3,9 @@
     "akas": [
       "{{ output.resource_aka.value }}"
     ],
+    "labels": {
+      "name": "test"
+    },
     "name": "{{ resourceName }}",
     "tags": {
       "name": "test"
diff --git a/gcp-test/tests/gcp_storage_bucket/test-turbot-query.sql b/gcp-test/tests/gcp_storage_bucket/test-turbot-query.sql
index f1286b98..f078c5a6 100644
--- a/gcp-test/tests/gcp_storage_bucket/test-turbot-query.sql
+++ b/gcp-test/tests/gcp_storage_bucket/test-turbot-query.sql
@@ -1,3 +1,3 @@
-select name, title, akas, tags
+select name, title, akas, labels, tags
 from gcp.gcp_storage_bucket
 where akas::text = '["{{ output.resource_aka.value }}"]'
\ No newline at end of file
diff --git a/gcp/table_gcp_storage_bucket.go b/gcp/table_gcp_storage_bucket.go
index ccbe3ddb..150513c1 100644
--- a/gcp/table_gcp_storage_bucket.go
+++ b/gcp/table_gcp_storage_bucket.go
@@ -100,7 +100,7 @@ func tableGcpStorageBucket(_ context.Context) *plugin.Table {
 			{
 				Name:        "labels",
 				Description: "Labels that apply to this bucket.",
-				Type:        proto.ColumnType_STRING,
+				Type:        proto.ColumnType_JSON,
 			},
 			{
 				Name:        "log_bucket",