Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot logo #542

Closed
michaeljs1990 opened this issue Apr 26, 2017 · 11 comments
Closed

Hot logo #542

michaeljs1990 opened this issue Apr 26, 2017 · 11 comments
Assignees

Comments

@michaeljs1990
Copy link
Contributor

michaeljs1990 commented Apr 26, 2017

Can we get a super sweet logo for collins? This will improve the user experience for me significantly since i sometimes find it hard to find collins when i have 20 tabs open and it has no favicon.

screen shot 2017-04-26 at 5 17 34 pm 😢

This is kinda random but I have this logo I had made for another project that I never launched. It's a sweet chihuahua that in no way relates to the name of this project except that I think we can all imagine it's name might be collins.

version 1 - color

@michaeljs1990
Copy link
Contributor Author

cc @byxorna @defect @roymarantz

@gtorre
Copy link
Contributor

gtorre commented May 9, 2017

I like it, 👍

@byxorna
Copy link
Contributor

byxorna commented May 18, 2017

@roymarantz @defect @komapa @ssalevan @maddalab what do you think? I like it as well...

How will it look at 16x16 though?

@michaeljs1990
Copy link
Contributor Author

image

so 16x16 not great i think at the 32x32 level it starts to look like something though.

@defect
Copy link
Contributor

defect commented May 19, 2017

I like it! I'm going to try spinning a collins container up with that as a favicon later to see what it looks like in the toolbar, but i'm sure it'll be a lot better than the default chrome or play one :)

We'll also need to check with legal on our side if there are any extra steps for contributions that aren't strictly code. I'll shoot them an email and let you guys know.

@defect
Copy link
Contributor

defect commented May 23, 2017

https://www.dropbox.com/s/lasukeqmgalzobb/Screenshot%202017-05-23%2008.57.07.png?dl=0

Looks OK at 16x16 to me in the Chrome tabs bar. Not great, but mostly due to me being lazy and not making the white background transparent :)

Do we need 16x16 though? Shouldn't most semi-recent versions of the most common browsers support at least 64x64?

@byxorna
Copy link
Contributor

byxorna commented May 23, 2017

Tbh all favicons look a bit bootleg, so if it doesn't look stellar I'm not too worried. Transparency would be nice though. Should this change include a bit of branding on the navbar and documentation as well?

Also, can you include screenshots of the tab with common browsers?

@grahamc
Copy link

grahamc commented Jun 1, 2017

This looks great. @defect It looks like you used a favicon and didn't also implement the higher resolution options available these days -- it might make the icon look much better: https://davidwalsh.name/retina-favicons

@defect
Copy link
Contributor

defect commented Jun 9, 2017

@grahamc Hehe yeah. I went early 2000s style for a worst-case :) Still looked pretty decent i thought! Especially if we can get some transparency in there.

Once we get legal sign-off I'll ask the frontend folks for advice, unless people here all ready know best practices for favicons.

@defect
Copy link
Contributor

defect commented Jul 17, 2017

Good news! We got the sign-off from legal. Sorry for the super long delay. Unless someone gets to it before me, I'll work on getting a PR out later this week. It's been a while since I did any frontend work though :)

@defect
Copy link
Contributor

defect commented Jul 26, 2017

Merged in #563. Thanks @michaeljs1990!

@defect defect closed this as completed Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants