Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type on runtime issue breakpoints #763

Closed
zenangst opened this issue Jun 20, 2023 · 2 comments
Closed

Add support for type on runtime issue breakpoints #763

zenangst opened this issue Jun 20, 2023 · 2 comments

Comments

@zenangst
Copy link
Contributor

After submitting a pull request to add runtime issue breakpoints to XcodeProj, @kwridan brought up the valid point that it should also include support for the options that accompany those runtime issue breakpoints.

However, this could have implications for the public API since BreakpointExtensionID is an enum with String as its .rawValue. This means that we cannot simply add associated objects to the enum.

The purpose of this issue is to explore potential solutions for what the public API could look like.

To cite what @kwridan wrote in the PR (link below)

From a quick trial, I've found the following:

  • Thread Sanitizer: type = 1
  • Undefined Behaviour: type = 2
  • Main thread checker: type = 4
  • System Frameworks: type = 8
  • All - type = 65535
    It appears to be a 16bit mask. It can be modelled as an option set. That said seeing it's only applicable to runtime exceptions it would mean it would be unused / optional for other types. I haven't quite figured out what a good public API for it would be. Perhaps can be done separately with some more thought put into it - mind raising an issue for it and if you have any ideas / suggestions?

Pull request: #761

@zenangst zenangst changed the title Add support for type on runtime issue Add support for type on runtime issue breakpoints Jun 20, 2023
@pepicrft pepicrft reopened this Jun 26, 2023
@github-actions
Copy link

Hola 👋,

We want to inform you that the issue has been marked as stale. This means that there hasn't been any activity or updates on it for quite some time, and it's possible that it may no longer be relevant or actionable.
If you still believe that this issue is valid and requires attention, please provide an update or any additional information that can help us address it. Otherwise, we may consider closing it in the near future.
Thank you for your understanding.

@github-actions github-actions bot added the stale label Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Hola 👋,

We want to inform you that we have decided to close this stale issue as there hasn't been any activity or response regarding it after marking it as stale.

We understand that circumstances may have changed or priorities may have shifted, and that's completely understandable. If you still believe that this issue needs to be addressed, please feel free to reopen it and provide any necessary updates or additional information.

We appreciate your understanding and look forward to your continued contributions to the project.

Thank you.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants