Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please specify rust-version #21

Closed
kornelski opened this issue Jun 16, 2024 · 4 comments
Closed

Please specify rust-version #21

kornelski opened this issue Jun 16, 2024 · 4 comments

Comments

@kornelski
Copy link

This crate uses just-released Rust 1.79 feature without specifying rust-version in Cargo.toml. This makes older Rust confuse users complaining about experimental features and barfing compilation errors, instead of clearly communicating that their Rust is too old.

@9mm
Copy link

9mm commented Jun 16, 2024

Now this says I have to use 1.79 and can't even use 1.78... is this the expected behavior?

@9mm
Copy link

9mm commented Jun 16, 2024

Im new to rust and just included the image crate. I dont believe I use inline consts but... i suppose it doesnt matter because I upgraded rust to 1.79

@kornelski
Copy link
Author

Oh, nevermind. I've noticed the problem was only in 2.4.0, and 2.4.1 has rust-version.

@EdJoPaTo
Copy link

@tuffy Given that 2.4.0 and 2.4.1 only differ in the rust-version being specified… Can you yank 2.4.0?

The upcoming edition 2024 / resolver=3 allows for fallback versions that work with a lower version. Testing it (rust-lang/cargo#13873) with a bunch of my projects quickly resulted in finding this crate where 2.4.0 is tried to be used which doesn't work better than 2.4.1. And as they are nearly identical, I'd suggest yanking 2.4.0 to reduce this pain point a bit.

PS: I like seeing the usage of more const!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants