Skip to content

Commit 35e60da

Browse files
committed
fix(slack-api): add response_type and text keys in slash command acknowledgement response to share in channel
1 parent f7671eb commit 35e60da

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

llmstack/apps/apis.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -803,9 +803,12 @@ def run(self, request, uid, session_id=None, platform=None):
803803
)
804804
response.is_async = True
805805
return response
806-
if request.data.get("command"):
806+
if platform == "slack" and request.data.get("command"):
807807
return DRFResponse(
808-
result["message"],
808+
data={
809+
"response_type": "in_channel",
810+
"text": result["message"],
811+
},
809812
status=200,
810813
headers={
811814
"Content-Security-Policy": result["csp"] if "csp" in result else "frame-ancestors self",

llmstack/apps/handlers/slack_app.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,7 @@ def __init__(self, *args, **kwargs):
6666

6767
is_valid_slash_command = False
6868
if self._request_slash_command and self._configured_slash_command:
69-
is_valid_slash_command = (
70-
self._request_slash_command == self._configured_slash_command and self._request_slash_command_text
71-
)
69+
is_valid_slash_command = self._request_slash_command == self._configured_slash_command
7270

7371
self._is_valid_slash_command = is_valid_slash_command
7472

@@ -252,8 +250,8 @@ def _is_app_accessible(self):
252250
elif self._request_type and not self._is_valid_request_type:
253251
error_message = "Invalid Slack request type. Only url_verification and event_callback are allowed."
254252

255-
if self._request_slash_command and not self._request_slash_command_text:
256-
error_message = f"Invalid Slash Command arguments. Command: `{self.request.data.get('command')}`. Arguments: `{self.request.data.get('text') or '-'}`"
253+
# elif self._request_slash_command and not self._request_slash_command_text:
254+
# error_message = f"Invalid Slash Command arguments. Command: `{self.request.data.get('command')}`. Arguments: `{self.request.data.get('text') or '-'}`"
257255

258256
elif self._request_type and not self._is_valid_request_type:
259257
error_message = f"Invalid Slack event request type - `{self._request_type}`"

0 commit comments

Comments
 (0)