Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack 2.0 dependency #57

Closed
tycooon opened this issue Feb 26, 2018 · 5 comments
Closed

Rack 2.0 dependency #57

tycooon opened this issue Feb 26, 2018 · 5 comments
Assignees

Comments

@tycooon
Copy link
Contributor

tycooon commented Feb 26, 2018

Hi, why is rack required for this gem? It can be used without web app at all, right? I have problems with some legacy app:

Bundler could not find compatible versions for gem "rack":
  In Gemfile:
    httplog (= 1.0.1) was resolved to 1.0.1, which depends on
      rack (~> 2.0)

    sprockets (~> 2.11.0) was resolved to 2.11.3, which depends on
      rack (~> 1.0)
@trusche
Copy link
Owner

trusche commented Feb 26, 2018

It's using Rack to decode HTTP status codes - see #46. Admittedly it could be done without. I'll see if I can make it less strict, it should work with Rack v1. Stay tuned.

@trusche trusche self-assigned this Feb 26, 2018
@trusche
Copy link
Owner

trusche commented Feb 26, 2018

I've loosened the dependency to rack >= 1.0. Could you give it a try from master, and if that solves your issue, I'll release it as a version bump?

@tycooon
Copy link
Contributor Author

tycooon commented Feb 26, 2018

It works, a new release would be cool!

@tycooon
Copy link
Contributor Author

tycooon commented Feb 26, 2018

By the way, it looks like some of gemfiles are missing in repo (http3 and rack2) and it's strange to me that travis is not complaining about that.

@trusche
Copy link
Owner

trusche commented Feb 26, 2018

They were still cached on Travis I assume. I added them back (was hoping I don' need to version that's in Gemfile.lock, but no dice).

v1.0.2 released.

@trusche trusche closed this as completed Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants