Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK_TOOLS_SASS has unexpected format requirements #541

Closed
lelgenio opened this issue May 2, 2023 · 9 comments · Fixed by #613
Closed

TRUNK_TOOLS_SASS has unexpected format requirements #541

lelgenio opened this issue May 2, 2023 · 9 comments · Fixed by #613
Labels

Comments

@lelgenio
Copy link
Contributor

lelgenio commented May 2, 2023

According to documentation TRUNK_TOOLS_SASS should have the same effect as setting tools.sass in Trunk.toml.

In the example Trunk.toml we have sass = "1.54.9", however in the implementation the entire first line of sass --version is used which is not always just the version.
Following current implentation, a correct example for the value would be something like 1.56.0 compiled with dart2js 2.18.4, which is not very good.

I would expect the value from the example Trunk.toml to work when used as the value for TRUNK_TOOLS_SASS.

@lelgenio
Copy link
Contributor Author

lelgenio commented May 2, 2023

Oh, this problems only happens with the javascript version of dart-sass, the native version does not have a suffix and only prints the current version.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 27, 2023
@lelgenio
Copy link
Contributor Author

ping

@github-actions github-actions bot removed the Stale label Aug 29, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 28, 2023
@lelgenio
Copy link
Contributor Author

@github-actions
image

@github-actions github-actions bot removed the Stale label Sep 29, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 29, 2023
@lelgenio
Copy link
Contributor Author

aaaaaaaaaaaaaaahhhhhhhhhhhhhhhgggggggggggggggggggggggggg

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 29, 2023
Copy link

github-actions bot commented Dec 5, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant