Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zed: Avoid core dump if wholedisk property does not exist #103

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

ixhamza
Copy link

@ixhamza ixhamza commented Oct 24, 2022

Motivation and Context

zed aborts and dumps core in vdev_whole_disk_from_config() if the wholedisk property does not exist. make_leaf_vdev() adds the property but there may be already pools that don't have the wholedisk in the label.
OpenZFS PR: openzfs#14062

How Has This Been Tested?

By creating pools through py-libzfs that did not populate the wholedisk parameter previously.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
@ixhamza ixhamza requested review from amotin, a user and usaleem-ix October 24, 2022 12:11
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to get this in for the freeze, but please also open a PR upstream for the zfs-2.1.7-staging branch.

@amotin amotin merged commit 3802eb7 into truenas/zfs-2.1-release Oct 25, 2022
@amotin amotin deleted the NAS-118697 branch October 25, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants