Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify resource-id versus proposal id in proposals-considered #182

Closed
catkins-miso opened this issue Oct 9, 2024 · 2 comments · Fixed by #194
Closed

Clarify resource-id versus proposal id in proposals-considered #182

catkins-miso opened this issue Oct 9, 2024 · 2 comments · Fixed by #194
Assignees
Labels
Spec Change Track specific spec changes ideas until they are complete. Should be placed into a milestone.

Comments

@catkins-miso
Copy link
Contributor

catkins-miso commented Oct 9, 2024

clarify that resource-id from proposals-considered is like the SEG id, and source.origin-id is like a correlation-id

@catkins-miso catkins-miso added the Spec Change Track specific spec changes ideas until they are complete. Should be placed into a milestone. label Oct 9, 2024
@catkins-miso catkins-miso added this to the Limit Characteristics milestone Oct 9, 2024
@catkins-miso catkins-miso self-assigned this Oct 9, 2024
@catkins-miso catkins-miso changed the title remove resource-id from proposals-considered as it is redundant with source.origin-id clarify that resource-id from proposals-considered is like the SEG id, and source.origin-id is like a correlation-id Oct 10, 2024
@catkins-miso catkins-miso changed the title clarify that resource-id from proposals-considered is like the SEG id, and source.origin-id is like a correlation-id Clarify resource-id versus proposal id in proposals-considered Oct 11, 2024
@catkins-miso
Copy link
Contributor Author

One question here @getorymckeag: "Do I use the SEG mrid as the primary resource id when I submit a proposal or the DYNELE mrid?"

Now, SEG id is effectively the Ratings Obligation identifier in TROLIE parlance, but we have not yet made the Ratings Obligation an explicit resource, but the resource-id in a proposal is the facility mrid, so the e.g. DYNELE mrid.

However, in the proposals-considered provenance info of a limits snapshot, I think the clearinghouse provider should populate the proposals-considered.resource-id with the SEG id. This would be useful in debugging any mapping issues.

@getorymckeag
Copy link
Contributor

One question here @getorymckeag: "Do I use the SEG mrid as the primary resource id when I submit a proposal or the DYNELE mrid?"

Now, SEG id is effectively the Ratings Obligation identifier in TROLIE parlance, but we have not yet made the Ratings Obligation an explicit resource, but the resource-id in a proposal is the facility mrid, so the e.g. DYNELE mrid.

However, in the proposals-considered provenance info of a limits snapshot, I think the clearinghouse provider should populate the proposals-considered.resource-id with the SEG id. This would be useful in debugging any mapping issues.

That's exactly what we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec Change Track specific spec changes ideas until they are complete. Should be placed into a milestone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants