Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no phyint config option does not work #36

Closed
Luth1ng opened this issue Sep 16, 2020 · 3 comments
Closed

no phyint config option does not work #36

Luth1ng opened this issue Sep 16, 2020 · 3 comments
Assignees
Milestone

Comments

@Luth1ng
Copy link

Luth1ng commented Sep 16, 2020

Hello there,

I am facing an issue while using the new "no phyint" option in /etc/mrouted.conf file.

I installed the 4.0 mrouted package through with OpenBSD 6.6 using:

./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var
make
make install-strip

I am using 100+ virtual interfaces (vlan/carp) on my system, and when I try to start mrouted with the "no phyint" option enabled and 3-4 interfaces enabled manually, I am still getting the following error:

warning - too many vifs, ignoring <if>
warning - /etc/mrouted.conf:29 phyint <if> not available, continuing . . . 
Cannot forward: only one enabled vif

(only one interface is enabled, because it's the first in the kernel list I guess).

It seems the "no phyint" option has no effect.
Any idea ?

Thanks
Luthing

@troglobit
Copy link
Owner

troglobit commented Sep 16, 2020

It works here, on Linux.

However, I noticed that it scans all legible kernel interfaces and says it installs them. Even though it, in a second pass, only activates the ones (adds them to the kernel) I've explicitly enabled.

mrouted: 19:07:54.890 Getting vifs from kernel interfaces
mrouted: 19:07:54.890 Installing wlan0 (192.168.1.195 on subnet 192.168.1/24) as VIF #0, rate 0 pps
mrouted: 19:07:54.890 Installing virbr0 (192.168.122.1 on subnet 192.168.122/24) as VIF #1, rate 0 pps
mrouted: 19:07:54.890 Installing wg0 (10.0.196.136 on subnet 10.0.196/24) as VIF #2, rate 0 pps
mrouted: 19:07:54.890 Getting vifs from test.conf
mrouted: 19:07:54.890 Installing vifs in mrouted ...
mrouted: 19:07:54.890 vif #1, phyint 192.168.122.1
mrouted: 19:07:54.890 vif #2, phyint 10.0.196.136

Looking closer at the code this is indeed the bug you've hit. Sorry about that. Unfortunately I cannot give you an estimate for a fix, but I'll see what I can do over the weekend. Should be fairly straight-forward since I know there's working code in the pimd project we can backport to mrouted. (pimd was derived from mrouted back in the day and shares a lot of the same code.)

@troglobit troglobit added this to the 4.1 milestone Sep 16, 2020
@troglobit troglobit self-assigned this Sep 16, 2020
@troglobit troglobit changed the title OpenBSD & no phyint config option no phyint config option does not work Sep 16, 2020
@troglobit troglobit changed the title no phyint config option does not work no phyint config option does not work Sep 16, 2020
@troglobit
Copy link
Owner

@Luth1ng There, took quite a bit longer than I'd initially hoped. Had to refactor the entire interface probing/install, so the chance of regressions is quite high. I'd really appreciate if you could help verify the latest master, or something newer than 22068c0.

@troglobit
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants