-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear preset stroke and fill colors of path elements #14
Comments
Hi @machacekmartin , Thank you for reporting it. I'm away at the moment so I will look at it in a couple of weeks. It was actually me who initially filed the original issue with them. At the time they weren't working on it so I implemented my own solution. I suspect that, in the latest release of my package, I forgot to remove my workaround. Once again, thanks for reporting it. Giulio |
@troccoli Happy to hear that! Please tag this when the fix is released :) |
Any updates on this? |
I had a look and it turned out I don't do anything with the actaul SVG. I could have fixed it myself as I did before but I didn't want to, as the goal, now that they release the icons in its own package, is to just use whatever they release and however they release them. After a big of digging, I found oout that they have just release a new version of the package, 1.0.1. You can find more information here. So, I have released verison 3.0.1 of my package that should resolve your issue. Thank you for reporting it. Giulio |
@troccoli Amazing, thank youuu! |
The source package had an issue, in which icons did not have
currentColor
,fill
, andstroke
set properly in order to easily manipulate their colors, instead, icons usually hadfill
of #333333 directly onpath
elementsOne of their PRs fixed it, the maintainers added a command (
remove-svg-backgrounds
) which should go through the svgs and update these attributes properly.I suspect your package does not use the command, since no .svg in the source folder has any
currentColor
attribute and still usesfill
andstroke
attributes on path elements (I may have overlooked something, but I haven't found any other solution).Please, could you make sure this package includes correct .svgs after they go through their command?
The text was updated successfully, but these errors were encountered: