From 778dfcd8c209fc208b23d767bafba6092f5887fe Mon Sep 17 00:00:00 2001 From: kai yong <okyspace@gmail.com> Date: Sun, 2 Apr 2023 19:37:37 +0800 Subject: [PATCH 1/5] Allow to customise args for tritonserver through values.yanl instead of editing the deployment.yaml. --- deploy/k8s-onprem/templates/deployment.yaml | 6 +++++- deploy/k8s-onprem/values.yaml | 4 ++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/deploy/k8s-onprem/templates/deployment.yaml b/deploy/k8s-onprem/templates/deployment.yaml index 6945cce23a..f2fcd5b86a 100644 --- a/deploy/k8s-onprem/templates/deployment.yaml +++ b/deploy/k8s-onprem/templates/deployment.yaml @@ -69,7 +69,11 @@ spec: limits: nvidia.com/gpu: {{ .Values.image.numGpus }} - args: ["tritonserver", "--model-repository=/models"] + args: + - tritonserver + {{- range .Values.additionalArgs }} + - {{.}} + {{- end }} ports: - containerPort: 8000 diff --git a/deploy/k8s-onprem/values.yaml b/deploy/k8s-onprem/values.yaml index 6e9e9e142f..8aa18e3748 100644 --- a/deploy/k8s-onprem/values.yaml +++ b/deploy/k8s-onprem/values.yaml @@ -35,6 +35,10 @@ image: modelRepositoryPath: /srv/models numGpus: 1 +# add additional args here e.g. --grpc-use-ssl, --grpc-server-certs, repository-poll-secs, etc +additionalArgs: + - '--model-repository=/models' + traefik: ports: triton-http: From 99e0b8ad4a4f1e892d5c60f13aac23467d10dcb3 Mon Sep 17 00:00:00 2001 From: kai yong <okyspace@gmail.com> Date: Thu, 6 Apr 2023 14:22:53 +0800 Subject: [PATCH 2/5] Change naming as requested by Triton reviewer. --- deploy/k8s-onprem/templates/deployment.yaml | 2 +- deploy/k8s-onprem/values.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/deploy/k8s-onprem/templates/deployment.yaml b/deploy/k8s-onprem/templates/deployment.yaml index f2fcd5b86a..bd8ddf85b0 100644 --- a/deploy/k8s-onprem/templates/deployment.yaml +++ b/deploy/k8s-onprem/templates/deployment.yaml @@ -71,7 +71,7 @@ spec: args: - tritonserver - {{- range .Values.additionalArgs }} + {{- range .Values.serverArgs }} - {{.}} {{- end }} diff --git a/deploy/k8s-onprem/values.yaml b/deploy/k8s-onprem/values.yaml index 8aa18e3748..9bc74f2c02 100644 --- a/deploy/k8s-onprem/values.yaml +++ b/deploy/k8s-onprem/values.yaml @@ -35,8 +35,8 @@ image: modelRepositoryPath: /srv/models numGpus: 1 -# add additional args here e.g. --grpc-use-ssl, --grpc-server-certs, repository-poll-secs, etc -additionalArgs: +# add server args here e.g. --grpc-use-ssl, --grpc-server-certs, repository-poll-secs, etc +serverArgs: - '--model-repository=/models' traefik: From 9901d0c686f0ca0083a57bd5a0f828b19be5d020 Mon Sep 17 00:00:00 2001 From: Kai Yong <okyspace@gmail.com> Date: Sat, 3 Jun 2023 09:59:10 +0800 Subject: [PATCH 3/5] Slight formatting as requested. --- deploy/k8s-onprem/templates/deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/k8s-onprem/templates/deployment.yaml b/deploy/k8s-onprem/templates/deployment.yaml index bd8ddf85b0..6ab4d06eff 100644 --- a/deploy/k8s-onprem/templates/deployment.yaml +++ b/deploy/k8s-onprem/templates/deployment.yaml @@ -72,7 +72,7 @@ spec: args: - tritonserver {{- range .Values.serverArgs }} - - {{.}} + - {{ . }} {{- end }} ports: From 634ec000457ceb3f55f5eda79a3867ffc7d02bf2 Mon Sep 17 00:00:00 2001 From: KY <55354225+okyspace@users.noreply.github.com> Date: Thu, 22 Feb 2024 22:04:40 +0800 Subject: [PATCH 4/5] Update deploy/k8s-onprem/templates/deployment.yaml Co-authored-by: Ryan McCormick <mccormick.codes@gmail.com> --- deploy/k8s-onprem/templates/deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/k8s-onprem/templates/deployment.yaml b/deploy/k8s-onprem/templates/deployment.yaml index d8cdb576d7..8c3a19d136 100644 --- a/deploy/k8s-onprem/templates/deployment.yaml +++ b/deploy/k8s-onprem/templates/deployment.yaml @@ -69,7 +69,7 @@ spec: limits: nvidia.com/gpu: {{ .Values.image.numGpus }} - args: + args: - tritonserver {{- range .Values.serverArgs }} - {{ . }} From 689c8c1b44574ad6e55c648195456297e4fec233 Mon Sep 17 00:00:00 2001 From: KY <55354225+okyspace@users.noreply.github.com> Date: Thu, 22 Feb 2024 22:05:26 +0800 Subject: [PATCH 5/5] Update deploy/k8s-onprem/values.yaml Co-authored-by: Ryan McCormick <mccormick.codes@gmail.com> --- deploy/k8s-onprem/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/k8s-onprem/values.yaml b/deploy/k8s-onprem/values.yaml index f569e72e91..d5a2c2d5ce 100644 --- a/deploy/k8s-onprem/values.yaml +++ b/deploy/k8s-onprem/values.yaml @@ -36,7 +36,7 @@ image: numGpus: 1 # add server args here e.g. --grpc-use-ssl, --grpc-server-certs, repository-poll-secs, etc -serverArgs: +serverArgs: - '--model-repository=/models' traefik: