Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Unnecessary Amesos2 dependence on Amesos" #983

Closed
wants to merge 1 commit into from

Conversation

krcb
Copy link
Contributor

@krcb krcb commented Jan 5, 2017

Reverts #918. This is a major change that needs to more review before it can be merged.

@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Jan 5, 2017
@krcb krcb closed this Jan 5, 2017
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Jan 5, 2017
@krcb krcb reopened this Jan 5, 2017
@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Jan 5, 2017
@krcb krcb closed this Jan 5, 2017
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Jan 5, 2017
@srajama1
Copy link
Contributor

srajama1 commented Jan 5, 2017

@krcb: The message here says there are unmerged commits. Do you know how to verify ?

@srajama1 srajama1 reopened this Jan 5, 2017
@srajama1 srajama1 added the stage: in progress Work on the issue has started label Jan 5, 2017
@krcb
Copy link
Contributor Author

krcb commented Jan 5, 2017

This is a PR to revert the changes from 918; I wasn't expecting these to be merged right now. As a result, I opened this PR to revert 918. The unmerged commits would be to revert 918.

@srajama1
Copy link
Contributor

srajama1 commented Jan 5, 2017

Got it ! Thanks !

@krcb
Copy link
Contributor Author

krcb commented Jan 6, 2017

PR #918 passed CI testing on 01/05/17. Closing this PR.

@krcb krcb closed this Jan 6, 2017
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Jan 6, 2017
@jmgate jmgate deleted the revert-918-suiteSparseRefactor branch September 20, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants