Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piro: work on the Hessain based implementation of ROL dot product #9501

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

mperego
Copy link
Contributor

@mperego mperego commented Jul 28, 2021

Generalization of the parameter list for defining Hessian based dot product.
Now the parameter list looks like:

  Matrix Based Dot Product:
    Matrix Type: Hessian Of Response
    Matrix Types:
      Hessian Of Response:
        Response Index: 0
        Block Diagonal Solver:
          Block 0:
            Linear Solver Type: Belos

At the moment Matrix Type can either be Identity (usual l2 dot product) or the Hessian Of Response.
The user also has to provide the Index of the Reponse used to compute the Hessian dot product

@trilinos/piro

Motivation

This makes the input file easier to read and allows to future extension to different matrix based dot product.

Testing

Modified Piro test input file to exercise the new syntax.

Generalization of  the parameter list for defining Hesian based dot product.
Now it looks like:

  Matrix Based Dot Product:
    Matrix Type: Hessian Of Response
    Matrix Types:
      Hessian Of Response:
        Response Index: 0
          Remove Mean Of The Right-hand Side: false
          Block Diagonal Solver:
            Block 0:
             Linear Solver Type: Belos

At the moment Matrix Type can either be the Identity (usual l2 dot product) or the Hessian of a Response.
One also has to provide the Idex of the Reponse used to compute the Hessian dot product

Modified Piro test input file accordingly.
@mperego mperego added type: enhancement Issue is an enhancement, not a bug pkg: Piro PA: Nonlinear Solvers Issues that fall under the Trilinos Nonlinear Linear Solvers Product Area client: Albany Issue impacting the Albany project labels Jul 28, 2021
@mperego mperego requested a review from kliegeois July 28, 2021 23:27
@mperego mperego self-assigned this Jul 28, 2021
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5177
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 2704
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3184
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 10447
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 1859
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 856
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3222
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 5734
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Using Repos:

Repo: TRILINOS (mperego/Trilinos)
  • Branch: develop
  • SHA: b484572
  • Mode: TEST_REPO

Pull Request Author: mperego

Copy link
Contributor

@kliegeois kliegeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 5177
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 2704
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 3184
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 10447
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105

  • Build Num: 1859
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_cuda_10.1.105_uvm_off

  • Build Num: 856
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 3222
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 5734
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS PA: Nonlinear Solvers;client: Albany;pkg: Piro;type: enhancement
PULLREQUESTNUM 9501
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA b484572
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 934b58b


CDash Test Results for PR# 9501.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ kliegeois ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@mperego mperego merged commit 19be9ac into trilinos:develop Jul 29, 2021
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Jul 30, 2021
…s:develop' (75f7aa5).

* trilinos-develop:
  Piro: work on the Hessain based implementation of ROL dot product (trilinos#9501)
  Panzer: fix compiler warnings in mesh factory tests
  Fixed bug in return type
  Panzer: make the edge/face block parameters consistent across mesh factories
jmgate pushed a commit to tcad-charon/Trilinos that referenced this pull request Jul 30, 2021
…s:develop' (75f7aa5).

* trilinos-develop:
  Piro: work on the Hessain based implementation of ROL dot product (trilinos#9501)
  Panzer: fix compiler warnings in mesh factory tests
  Fixed bug in return type
  Panzer: make the edge/face block parameters consistent across mesh factories
PhilMiller pushed a commit to PhilMiller/Trilinos that referenced this pull request Dec 22, 2021
…develop' (4976465).

* trilinos/develop:
  Piro: work on the Hessain based implementation of ROL dot product (trilinos#9501)
  Panzer: fix compiler warnings in mesh factory tests
  Fixed bug in return type
  Panzer: make the edge/face block parameters consistent across mesh factories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: Albany Issue impacting the Albany project PA: Nonlinear Solvers Issues that fall under the Trilinos Nonlinear Linear Solvers Product Area pkg: Piro type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants