Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piro: fix incorrect calculation of trapezoid rule time step #7928

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Piro: fix incorrect calculation of trapezoid rule time step #7928

merged 1 commit into from
Aug 28, 2020

Conversation

lxmota
Copy link
Contributor

@lxmota lxmota commented Aug 28, 2020

@trilinos/piro

The computation of the time step for the trapezoid rule when the initial time is not zero is incorrect.

Stakeholder Feedback

Testing

@lxmota lxmota added pkg: Piro AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed client: LCM Solid mechanics fork of Albany labels Aug 28, 2020
@lxmota lxmota requested a review from ikalash August 28, 2020 00:26
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7691
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7501
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5926
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 146
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1962
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5258
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 407
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3257
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3278
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: piro-tr-time-step
  • SHA: aee6cf9
  • Mode: TEST_REPO

Pull Request Author: lxmota

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7691
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7501
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5926
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 146
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1962
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5258
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 407
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3257
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3278
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;client: LCM;pkg: Piro
PULLREQUESTNUM 7928
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH piro-tr-time-step
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA aee6cf9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 938de38


CDash Test Results for PR# 7928.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ikalash ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 6761d1a into develop Aug 28, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 7928: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 28, 2020
@lxmota lxmota deleted the piro-tr-time-step branch August 28, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikalash ikalash ikalash approved these changes

Assignees
No one assigned
Labels
client: LCM Solid mechanics fork of Albany pkg: Piro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxmota @trilinos-autotester @ikalash