Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempus: set Rel/Abs to currentstate for optimal initdt #7916

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Tempus: set Rel/Abs to currentstate for optimal initdt #7916

merged 1 commit into from
Aug 26, 2020

Conversation

sconde
Copy link
Contributor

@sconde sconde commented Aug 26, 2020

@trilinos/tempus

Motivation

Set tolerance to workingstate

Stakeholder Feedback

Testing

@sconde sconde requested review from ccober6 and seamill August 26, 2020 17:44
@sconde sconde self-assigned this Aug 26, 2020
@sconde sconde added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: Tempus labels Aug 26, 2020
ccober6
ccober6 previously approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@ccober6 ccober6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You may want to name the variable cs instead of ws to avoid confusion.

@sconde sconde force-pushed the tempus-update-tolerance-init-dt branch from 3b9a92d to 0044ede Compare August 26, 2020 18:12
@sconde sconde requested a review from ccober6 August 26, 2020 18:12
@sconde
Copy link
Contributor Author

sconde commented Aug 26, 2020

@ccober6 I made the change. Can I get a review again please

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7675
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7485
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5910
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 130
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1946
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5242
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 391
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3244
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3265
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: tempus-update-tolerance-init-dt
  • SHA: 0044ede
  • Mode: TEST_REPO

Pull Request Author: sconde

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7675
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7485
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5910
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 130
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1946
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5242
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 391
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3244
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3265
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;pkg: Tempus
PULLREQUESTNUM 7916
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tempus-update-tolerance-init-dt
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 0044ede
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3


CDash Test Results for PR# 7916.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ seamill ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 25f437e into develop Aug 26, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 7916: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 26, 2020
@sconde sconde deleted the tempus-update-tolerance-init-dt branch August 27, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamill seamill seamill approved these changes

@ccober6 ccober6 Awaiting requested review from ccober6

Assignees

@sconde sconde

Labels
pkg: Tempus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sconde @trilinos-autotester @ccober6 @seamill