Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: Update RegionRFactory unit test to use coordinate maps #7912

Merged
merged 1 commit into from
Aug 26, 2020
Merged

MueLu: Update RegionRFactory unit test to use coordinate maps #7912

merged 1 commit into from
Aug 26, 2020

Conversation

GrahamBenHarper
Copy link
Contributor

@trilinos/muelu

Motivation

Previously the unit test assumed the coordinate map is the same as the row map. That is only true in the case of one DOF per node. This change is necessary to support multiple DOFs per node on the RegionRFactory unit tests.

Stakeholder Feedback

Testing

I reran all MueLu unit tests on Skybridge and they pass.

@GrahamBenHarper GrahamBenHarper requested a review from lucbv August 26, 2020 17:21
@GrahamBenHarper GrahamBenHarper requested a review from a team as a code owner August 26, 2020 17:21
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7672
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7482
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5907
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 127
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1943
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5239
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 388
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3242
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3263
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Using Repos:

Repo: TRILINOS (GrahamBenHarper/Trilinos)
  • Branch: RegionRUnitTest
  • SHA: 4e1b606
  • Mode: TEST_REPO

Pull Request Author: GrahamBenHarper

lucbv
lucbv approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the coordinates map it looks better!

mayrmt
mayrmt approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@mayrmt mayrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GrahamBenHarper GrahamBenHarper added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed pkg: MueLu labels Aug 26, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 7672
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 7482
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 5907
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 127
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 1943
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 5239
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 388
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 3242
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 3263
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS
PULLREQUESTNUM 7912
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH RegionRUnitTest
TRILINOS_SOURCE_REPO https://github.com/GrahamBenHarper/Trilinos
TRILINOS_SOURCE_SHA 4e1b606
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 5c4cce3


CDash Test Results for PR# 7912.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv mayrmt ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 37c0cc0 into trilinos:develop Aug 26, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 7912: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 26, 2020
@GrahamBenHarper GrahamBenHarper deleted the RegionRUnitTest branch September 9, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayrmt mayrmt mayrmt approved these changes

@lucbv lucbv lucbv approved these changes

Assignees
No one assigned
Labels
pkg: MueLu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GrahamBenHarper @trilinos-autotester @mayrmt @lucbv