Intrepid2: Enable projections for Continuous Hierarchical Basis #7201
Conversation
mperego
added
type: enhancement
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
@CamelliaDPG Another couple of things.
|
|
NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester... |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 6355 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 6179 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 4607 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 4454 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 643 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 3972 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_9.0.0 # 345 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 2146 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 2157 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 6357 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 6181 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 4609 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 4456 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 645 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 3974 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_9.0.0 # 347 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 2148 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 2159 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 6358 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 6182 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 4610 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 4457 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 646 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 3975 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_9.0.0 # 348 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 2149 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 2160 (click to expand) |
|
Um.. everything is fine except a few integration tests randomly timing out. Setting the WIP flag for now, untill the review is in. |
mperego
added
the
AT: WIP
@mperego Sounds fine. Yes, IIRC,
Makes sense. I'll work on getting #7071 addressed soon (maybe even today).
There isn't a direct way to tell whether a basis is DG; what I do in e.g. the BasisEquivalenceTests is just check whether there are any dofs not associated with the element interior (the definition of a DG basis: all dofs are associated with the element interior). It would be easy enough to implement something in the base class that performed exactly this check. Maybe a method with signature ? Thanks for your patience on this review. I haven't looked at your code yet; that's next. |
Yes, I removed the unnatural ones. I'm fine keeping it if you like. I'm worried that the unnatural basis generate a different functional space. Also, it should be tested if we keep it there.
Thanks, you do not have to address this before this PR.
Sounds good. We could also add the DG functional spaces to the
No worries! Thanks for working on it now. |
There was a problem hiding this comment.
@mperego, overall, looks good — and looks like quite a bit of work! Nice to have the hierarchical bases supported by the projections, and nice too to have the projections happening on device.
Once you've addressed my various comments, let me know and I'll approve. Thanks!
| // subcell parameterization should be small computation (numPts is small) and it should be decorated with | ||
| // kokkos inline... let's not do this yet | ||
| // Apply the parametrization map to every point in parameter domain | ||
| mapToReferenceSubcell( refSubcellPoints, paramPoints, subcellMap, subcellDim, subcellOrd, parentCell.getDimension()); |
There was a problem hiding this comment.
Might it be better to place this call within a Kokkos block, so that it actually gets run on device?
There was a problem hiding this comment.
The reason for making this function run on device is so that we can call it within a parallel loop over cells, as we do in the Projections. However, here we are only working on a reference cell.
packages/intrepid2/src/Discretization/Basis/Intrepid2_DerivedBasis_HDIV_HEX.hpp
Show resolved
Hide resolved
| @@ -937,7 +937,7 @@ namespace Intrepid2 | |||
| int fieldOrdinal = (fieldOrdinal3 * numFields2_ + fieldOrdinal2) * numFields1_ + fieldOrdinal1; | |||
| for (int pointOrdinal=0; pointOrdinal<numPoints_; pointOrdinal++) | |||
| { | |||
| output_(fieldOrdinal,pointOrdinal) = weight_ * input1_(fieldOrdinal1,pointOrdinal) * input2_(fieldOrdinal2,pointOrdinal) * input3_(fieldOrdinal3,pointOrdinal); | |||
| output_(fieldOrdinal,pointOrdinal,0) = weight_ * input1_(fieldOrdinal1,pointOrdinal,0) * input2_(fieldOrdinal2,pointOrdinal,0) * input3_(fieldOrdinal3,pointOrdinal,0); | |||
There was a problem hiding this comment.
I don't understand this change (the addition of the 0 as third argument for output_, input1_, and input2_). The if clause above establishes that input1_ and input2_ are both rank 2 containers, so output_ should be as well, and they should take only 2 arguments. Am I missing something?
There was a problem hiding this comment.
The reason why I put the extra arguments comes from an error I got in debug mode. Basically the output of getValue(..,..,OPERATOR_GRAD) for a 1d basis has rank 3. This generated an error in some of the lines you pointed out because we were providing two arguments instead of three. In a DynRankView, it is OK to provide more arguments than the rank, but no less.
Anyway, looking at it more carefully, I think I understand better what you where trying to do, however to make it work you have to change the condition
https://github.com/trilinos/Trilinos/blob/master/packages/intrepid2/src/Discretization/Basis/Intrepid2_TensorBasis.hpp#L932
to if ((input1_.rank() == 2) && (input2_.rank() == 2)) && (input3_.rank()==3))
Also, there was an error here:
https://github.com/trilinos/Trilinos/blob/master/packages/intrepid2/src/Discretization/Basis/Intrepid2_TensorBasis.hpp#L973
in fact the third argument was provided to input3_ instead of input2_. That's a bit concerning. I'm wondering if in that case input2_.extent(2) is always 1.
Anyway, have a look at the way I fixed it and let me know if you are fine with that.
| @@ -953,7 +953,7 @@ namespace Intrepid2 | |||
| { | |||
| for (int d=0; d<spaceDim; d++) | |||
| { | |||
| output_(fieldOrdinal,pointOrdinal,d) = weight_ * input1_(fieldOrdinal1,pointOrdinal,d) * input2_(fieldOrdinal2,pointOrdinal) * input3_(fieldOrdinal3,pointOrdinal); | |||
| output_(fieldOrdinal,pointOrdinal,d) = weight_ * input1_(fieldOrdinal1,pointOrdinal,d) * input2_(fieldOrdinal2,pointOrdinal,0) * input3_(fieldOrdinal3,pointOrdinal,0); | |||
There was a problem hiding this comment.
Same thing here as regards the extra "0" arguments.
| @@ -987,7 +987,7 @@ namespace Intrepid2 | |||
| { | |||
| for (int d=0; d<spaceDim; d++) | |||
| { | |||
| output_(fieldOrdinal,pointOrdinal,d) = weight_ * input1_(fieldOrdinal1,pointOrdinal) * input2_(fieldOrdinal2,pointOrdinal) * input3_(fieldOrdinal3,pointOrdinal,d); | |||
| output_(fieldOrdinal,pointOrdinal,d) = weight_ * input1_(fieldOrdinal1,pointOrdinal,0) * input2_(fieldOrdinal2,pointOrdinal,0) * input3_(fieldOrdinal3,pointOrdinal,d); | |||
packages/intrepid2/src/Projection/Intrepid2_ProjectionStructDef.hpp
Outdated
Show resolved
Hide resolved
packages/intrepid2/src/Projection/Intrepid2_ProjectionStructDef.hpp
Outdated
Show resolved
Hide resolved
packages/intrepid2/unit-test/Projection/test_interpolation_projection_HEX.hpp
Show resolved
Hide resolved
No, I'm happy to be rid of the unnatural ones! Thanks for fixing that.
That's an interesting idea. The DG spaces are "broken" versions of the CG spaces; element-wise, they conform to the same space as the CG version, but globally they do not conform. So the question is what the function space associated with the basis means: does it answer the global or the local question of conformity? I've been proceeding on the idea that local conformity is what's intended. |
addressing discussion in PR trilinos#7201
There was a problem hiding this comment.
There isn't a direct way to tell whether a basis is DG; what I do in e.g. the BasisEquivalenceTests is just check whether there are any dofs not associated with the element interior (the definition of a DG basis: all dofs are associated with the element interior). It would be easy enough to implement something in the base class that performed exactly this check. Maybe a method with signature
bool isDGBasis() const;?
Sounds good. We could also add the DG functional spaces to the
EFunctionSpace enum.That's an interesting idea. The DG spaces are "broken" versions of the CG spaces; element-wise, they conform to the same space as the CG version, but globally they do not conform. So the question is what the function space associated with the basis means: does it answer the global or the local question of conformity? I've been proceeding on the idea that local conformity is what's intended.
I gave it some more thoughts, and I think that what you currently do is the best approach. In fact you could use a "CG" basis to generate broken spaces, so you cannot infer the global space at the local level, and methods like isDGBasis() could be misleading. Does it make sense?
| // subcell parameterization should be small computation (numPts is small) and it should be decorated with | ||
| // kokkos inline... let's not do this yet | ||
| // Apply the parametrization map to every point in parameter domain | ||
| mapToReferenceSubcell( refSubcellPoints, paramPoints, subcellMap, subcellDim, subcellOrd, parentCell.getDimension()); |
There was a problem hiding this comment.
The reason for making this function run on device is so that we can call it within a parallel loop over cells, as we do in the Projections. However, here we are only working on a reference cell.
packages/intrepid2/unit-test/Projection/test_interpolation_projection_HEX.hpp
Show resolved
Hide resolved
mperego
removed
the
AT: WIP
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 6467 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 6293 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 4719 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 4566 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 755 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 4083 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_9.0.0 # 456 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 2250 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 2261 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
mperego
added
AT: WIP
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 6783 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 6595 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 5020 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 4867 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_8.3.0 # 1057 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 4357 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_clang_9.0.0 # 732 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_2 # 2494 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_python_3 # 2505 (click to expand) |
trilinos-autotester
removed
the
AT: RETEST
- made dependency on KokkosKernels optional
- improved solution of element projections by
re-using matrix factorization when possible
|
@CamelliaDPG Can you look at it one more time? Just the last commit. |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: mperego |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_9.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
3 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
There was a problem hiding this comment.
@mperego, these changes look good to me. Congratulations on getting things passing! Seems like it's been quite a headache…
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ CamelliaDPG ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
|
A dream come true.. After days and days of suspense and anxiety, my work has been deemed acceptable by the mighty Trilinos autotester! Hahaha |
@trilinos/intrepid2
Motivation
This PR enables the projections tools for the recently implemented hierarchical basis functions.
It also improves the parallelization of the projection tools by using the QR factorization provided by
KokkosKernels. (thanks to @kyungjoo-kim for helping with that).Note, this PR adds a required dependency on
Kokkos Kernels.Stakeholder Feedback
Testing
Projection tests have been modified to exercise the use of Hierarchical basis functions.
In particular we test projection for the following Hierarchical function spaces:
HGRAD_HEX, HGRAD_TET, HGRAD_QUAD, HGRAD_TRI, HCURL_HEX, HCURL_QUAD, HDIV_HEX, HDIV_QUAD, HVOL_HEX, HVOL_QUADSome projection tests are now run also on OpenMP and Cuda.