Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Edit CMakeLists to not check for Kokkos UVM if Tpetra disables CUDA #7155

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Tpetra: Edit CMakeLists to not check for Kokkos UVM if Tpetra disables CUDA #7155

merged 1 commit into from
Aug 5, 2020

Conversation

johelli
Copy link
Contributor

@johelli johelli commented Apr 10, 2020 •
edited
Loading

...and Kokkos enables CUDA.

Allow Tpetra to build without CUDA without implicitly assuming Kokkos_ENABLE_CUDA implies Tpetra_ENABLE_CUDA.

@trilinos/tpetra

Motivation

A Trilinos build with serial Tpetra was required that had Kokkos_ENABLE_CUDA without Kokkos_ENABLE_CUDA_UVM. Previously, a CMake assert error was not allowing this case.

Stakeholder Feedback

It is rare to need Kokkos CUDA but not a CUDA(w/ UVM) enabled Tpetra, so this change should impact no current users.

Testing

Tested on Waterman (P9/Volta). Ensured that the target build case builds.

@johelli johelli added type: bug The primary issue is a bug in Trilinos code or tests pkg: Tpetra system: gpu labels Apr 10, 2020
@johelli johelli requested a review from kddevin April 10, 2020 22:49
@johelli johelli self-assigned this Apr 10, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6272
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6097
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 4524
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4371
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 560
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 3890
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 263
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2074
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2085
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Using Repos:

Repo: TRILINOS (johelli/Trilinos)
  • Branch: tpetra-cmake-kokkos-enable-cuda-mod
  • SHA: c576490
  • Mode: TEST_REPO

Pull Request Author: johelli

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 6272
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 6097
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 4524
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 4371
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 560
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 3890
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_clang_9.0.0

  • Build Num: 263
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 2074
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 2085
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 7155
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra-cmake-kokkos-enable-cuda-mod
TRILINOS_SOURCE_REPO https://github.com/johelli/Trilinos
TRILINOS_SOURCE_SHA c576490
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 488aa31


CDash Test Results for PR# 7155.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

3 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

kddevin
kddevin previously requested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@kddevin kddevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johelli Would you please add the CMake command you used when testing? Also, with this configuration, did the Tpetra tests run correctly? Thanks.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@kddevin kddevin mentioned this pull request Apr 14, 2020
Merged
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

1 similar comment
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester trilinos-autotester added the AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration label Apr 17, 2020
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

8 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

13 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

9 similar comments
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@kddevin kddevin dismissed their stale review August 4, 2020 19:23

Tests are passing

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley kddevin ]!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However PR is now STALE, and must be retested. Set the AT: RETEST Label to force retest....

@johelli johelli merged commit 3ecb427 into trilinos:develop Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-kelley brian-kelley brian-kelley approved these changes

@kddevin kddevin kddevin approved these changes

Assignees

@johelli johelli

Labels
AT: STALE Added by the PR autotester if too much time has elapsed since the last successful PR test iteration pkg: Tpetra system: gpu type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johelli @trilinos-autotester @brian-kelley @kddevin