Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempus: Add Improved Doc for DIRK #6710

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Tempus: Add Improved Doc for DIRK #6710

merged 1 commit into from
Feb 2, 2020

Conversation

ccober6
Copy link
Contributor

@ccober6 ccober6 commented Jan 31, 2020

Added latex algorithm documentation to DIRK stepper.
Also did some algorithm cleanup, which basically swapped
FSAL work and checking for the need to compute the stageXDot.
This better handles some "corner cases".

Passes all tests.

@trilinos/tempus

Closes #6703

@ccober6
Tempus: Add Improved Doc for DIRK
b79b799 
Added latex algorithm documentation to DIRK stepper.
Also did some algorithm cleanup, which basically swapped
FSAL work and checking for the need to compute the stageXDot.
This better handles some "corner cases".

Passes all tests.
@ccober6 ccober6 added impacting: documentation The issue is primarily about documentation vs. a problem with the build or tests pkg: Tempus AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) client: EMPIRE All issues that most directly target the ATDM EMPIRE code labels Jan 31, 2020
@ccober6 ccober6 self-assigned this Jan 31, 2020
@ccober6
Copy link
Contributor Author

ccober6 commented Jan 31, 2020

Leaving as WIP, while I test against EMPIRE.

@ccober6
Copy link
Contributor Author

ccober6 commented Feb 1, 2020

Ok, this is passing EMPIRE tests. Let's get it merged.

@ccober6 ccober6 requested review from rppawlo and sconde February 1, 2020 11:00
@ccober6 ccober6 added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed and removed AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels Feb 1, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 5598
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 5423
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3852
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3700
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 3237
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 1513
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 1512
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
  • SHA: b79b799
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 5598
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 5423
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3852
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3700
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 3237
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 1513
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 1512
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6710
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA b79b799
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 4cfa684


CDash Test Results for PR# 6710.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

1 similar comment
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 200c15e into develop Feb 2, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 6710: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Feb 2, 2020
@ccober6 ccober6 deleted the 6703-Tempus-Improve-Documentation-of-DIRK-Stepper-Algorithm branch March 12, 2020 14:11
@trilinos-autotester trilinos-autotester mentioned this pull request May 15, 2020
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rppawlo rppawlo rppawlo approved these changes

@sconde sconde Awaiting requested review from sconde

Assignees

@ccober6 ccober6

Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code impacting: documentation The issue is primarily about documentation vs. a problem with the build or tests pkg: Tempus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccober6 @trilinos-autotester @rppawlo