Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: index change from #6598 #6606

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Tpetra: index change from #6598 #6606

merged 1 commit into from
Jan 19, 2020

Conversation

kddevin
Copy link
Contributor

@kddevin kddevin commented Jan 17, 2020

@trilinos/tpetra

Motivation

In #6598, @mhoemmen recommended using index jj instead of index j to compute offsets to communication buffers. This PR implements that change.

Stakeholder Feedback

Testing

Configuration and testing is identical to #6598
ested on linux with Tpetra tests and downstream packages Belos, Ifpack2, MueLu, Zoltan2, and Teko.

source ../cmake/std/atdm/load-env.sh  gnu-7.2.0-openmp-release-debug
cmake \
  -GNinja \
  -DMPI_EXEC=${MPI_EXEC} \
  -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
  -DTrilinos_ENABLE_TESTS=ON  \
  -DTrilinos_ENABLE_Tpetra=ON \
  -DTrilinos_ENABLE_MueLu=ON \
  -DTrilinos_ENABLE_Anasazi=ON \
  -DTrilinos_ENABLE_Belos=ON \
  -DTrilinos_ENABLE_Ifpack2=ON \
  -DTrilinos_ENABLE_Zoltan2=ON \
  -DTrilinos_ENABLE_Teko=ON \
.. |& tee OUTPUT.CMAKE

100% tests passed, 0 tests failed out of 558

Subproject Time Summary:
Belos      = 183.91 sec*proc (99 tests)
Ifpack2    =  61.39 sec*proc (44 tests)
MueLu      = 757.94 sec*proc (63 tests)
Teko       = 152.59 sec*proc (18 tests)
Tpetra     = 341.18 sec*proc (221 tests)
Zoltan2    = 246.19 sec*proc (113 tests)

@kddevin kddevin added pkg: Tpetra AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Jan 17, 2020
@kddevin kddevin requested a review from mhoemmen January 17, 2020 23:27
@kddevin kddevin self-assigned this Jan 17, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 5417
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 5242
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3671
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3519
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 3067
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 1361
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 1360
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: tpetra_6598_followOn
  • SHA: 02f90a9
  • Mode: TEST_REPO

Pull Request Author: kddevin

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 5417
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 5242
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3671
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3519
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 3067
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 1361
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 1360
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6606
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH tpetra_6598_followOn
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 02f90a9
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 630dfd2


CDash Test Results for PR# 6606.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

1 similar comment
@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

mhoemmen
mhoemmen approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-D

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit ebdb4cb into develop Jan 19, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 6606: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 19, 2020
@kddevin kddevin deleted the tpetra_6598_followOn branch January 20, 2020 06:15
@trilinos-autotester trilinos-autotester mentioned this pull request May 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

Assignees

@kddevin kddevin

Labels
pkg: Tpetra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kddevin @trilinos-autotester @mhoemmen