Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piro: fix redundant calls to observeSolution #6513

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Piro: fix redundant calls to observeSolution #6513

merged 1 commit into from
Jan 3, 2020

Conversation

mperego
Copy link
Contributor

@mperego mperego commented Jan 2, 2020

Motivation

It fixes Albany issues related to increased number of time steps in Exodus mesh

Stakeholder Feedback

Testing

@mperego mperego added pkg: Piro AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Jan 2, 2020
@mperego mperego requested a review from ikalash January 2, 2020 19:27
@mperego mperego requested a review from a team as a code owner January 2, 2020 19:27
@mperego mperego changed the base branch from master to develop January 2, 2020 19:27
@mperego mperego removed the request for review from a team January 2, 2020 20:09
@mperego mperego added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Jan 2, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 5302
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 5127
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3556
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3404
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2958
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 1268
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 1268
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Using Repos:

Repo: TRILINOS (mperego/Trilinos)
  • Branch: develop
  • SHA: d34778d
  • Mode: TEST_REPO

Pull Request Author: mperego

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 5302
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 5127
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3556
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3404
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2958
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 1268
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 1268
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6513
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/mperego/Trilinos
TRILINOS_SOURCE_SHA d34778d
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 647ae4e


CDash Test Results for PR# 6513.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Jan 3, 2020
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 53dfe7f into trilinos:develop Jan 3, 2020
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 6513: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 3, 2020
@ikalash
Copy link
Contributor

ikalash commented Jan 3, 2020

Thanks for doing this! I will check the Albany tests tomorrow to verify that the failures are fixed. Please stay tuned.

@ikalash
Copy link
Contributor

ikalash commented Jan 4, 2020

I see this was already merged. Seems it fixed the tests in Albany - thanks for doing that!

@ikalash ikalash mentioned this pull request Jan 4, 2020
Closed
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 28, 2020
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rppawlo rppawlo rppawlo approved these changes

@ikalash ikalash Awaiting requested review from ikalash

Assignees
No one assigned
Labels
pkg: Piro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mperego @trilinos-autotester @ikalash @rppawlo