Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: UncoupledAggregation_kokkos fixes #6268

Merged
merged 2 commits into from
Nov 13, 2019
Merged

MueLu: UncoupledAggregation_kokkos fixes #6268

merged 2 commits into from
Nov 13, 2019

Conversation

cgcgcg
Copy link
Contributor

@cgcgcg cgcgcg commented Nov 13, 2019

@trilinos/muelu

Motivation

  • UncoupledAggregation_kokkos was ignoring Dirichlet nodes.
  • TentativeP_kokkos did not compress the matrix correctly for nullspace of dim = 1.

@cgcgcg cgcgcg added pkg: MueLu client: EMPIRE All issues that most directly target the ATDM EMPIRE code labels Nov 13, 2019
@cgcgcg cgcgcg requested a review from a team as a code owner November 13, 2019 17:58
@cgcgcg cgcgcg self-assigned this Nov 13, 2019
@lucbv lucbv mentioned this pull request Nov 13, 2019
Closed
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4928
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4757
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3186
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3013
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2587
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 959
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 959
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Using Repos:

Repo: TRILINOS (cgcgcg/Trilinos)
  • Branch: aggFix
  • SHA: 2fb43da
  • Mode: TEST_REPO

Pull Request Author: cgcgcg

lucbv
lucbv approved these changes Nov 13, 2019
View reviewed changes
packages/muelu/src/Graph/UncoupledAggregation/MueLu_UncoupledAggregationFactory_kokkos_def.hpp
// for (LO i = 0; i < numRows; i++)
// if (dirichletBoundaryMap[i] == true)
// aggStat[i] = BOUNDARY;
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added issue #6269 so we don't forget to improve this bit of code later

@cgcgcg cgcgcg mentioned this pull request Nov 13, 2019
Closed
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4928
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4757
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3186
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 3013
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2587
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 959
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 959
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6268
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH aggFix
TRILINOS_SOURCE_REPO https://github.com/cgcgcg/Trilinos
TRILINOS_SOURCE_SHA 2fb43da
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 2d17380


CDash Test Results for PR# 6268.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

@rppawlo
Copy link
Contributor

rppawlo commented Nov 13, 2019

@cgcgcg looks like this has been approved and passed PR testing. Did you want this merged?

@cgcgcg cgcgcg merged commit e232ef4 into trilinos:develop Nov 13, 2019
@jhux2
Copy link
Member

jhux2 commented Nov 14, 2019

@cgcgcg Did you by any chance see if this affected the Kokkos-path negative # of aggregates problem?

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Nov 14, 2019

Not yet. I'll have to pull and rebuild on lassen..

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Nov 14, 2019

@jhux2 Nope, not fixed.

@cgcgcg cgcgcg deleted the aggFix branch October 22, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees

@cgcgcg cgcgcg

Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code pkg: MueLu
Projects
MueLu
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cgcgcg @trilinos-autotester @rppawlo @jhux2 @lucbv