Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATDM: Set Amesos2_ENABLE_Epetra=OFF unconditionally (ATDV-202) #6104

Merged
merged 1 commit into from
Oct 16, 2019
Merged

ATDM: Set Amesos2_ENABLE_Epetra=OFF unconditionally (ATDV-202) #6104

merged 1 commit into from
Oct 16, 2019

Conversation

bartlettroscoe
Copy link
Member

This is set in EMPIRE's native configuration driver and therefore should be
set unconditionally. Before, it was only set for the SPARC configuration.

I missed this somehow when doing ATDV-202 (or it was not set in the EM-Plamsa/BuildScripts repo script at that time).

See:

@bartlettroscoe
ATDM: Set Amesos2_ENABLE_Epetra=OFF unconditionally (ATDV-202)
ce9eeeb 
This is set in EMPIRE's native configuration driver and therefore should be
set unconditionally.  Before, it was only set for the SPARC configuration.
@bartlettroscoe bartlettroscoe added type: enhancement Issue is an enhancement, not a bug ATDM Config Issues that are specific to the ATDM configuration settings client: EMPIRE All issues that most directly target the ATDM EMPIRE code AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams labels Oct 16, 2019
@bartlettroscoe bartlettroscoe requested a review from jmgate October 16, 2019 14:36
@bartlettroscoe
Copy link
Member Author

FYI: Just to be safe, I tested this on 'crf450' with:

$ cd ~/Trilinos.base/BUILDS/ATDM/SEMS-RHEL6/CHECKIN/

$  ./checkin-test-atdm.sh \
    sems-rhel6-gnu-7.2.0-openmp-opt-dbg \
    --enable-packages=Amesos2 --local-do-all

which gave test results:

  100% tests passed, 0 tests failed out of 5
  
  Subproject Time Summary:
  Amesos2    =   3.70 sec*proc (5 tests)
  
  Total Test time (real) =   0.43 sec
  
  Total time for sems-rhel6-gnu-7.2.0-openmp-opt-dbg = 3.31 min

Since:

  • This setting is already in place for the SPARC ATDM Trilinos confiugrations for the 'cee-rhel6' and 'waterman' envs so we know it works with SPARC
  • We know that EMPIRE works with the SPARC ATDM Trilinos configuration
  • We know EMPIRE's configure of Trilinos already had this set as per https://cee-gitlab.sandia.gov/EM-Plasma/BuildScripts/merge_requests/227

therefore I don't think any direct testing against SPARC or EMPIRE is needed to safely merge this.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4746
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4573
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3004
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2832
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2405
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 796
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 796
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Using Repos:

Repo: TRILINOS (bartlettroscoe/Trilinos)
  • Branch: atdv-202-amesos-enable-epetra-off
  • SHA: ce9eeeb
  • Mode: TEST_REPO

Pull Request Author: bartlettroscoe

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4746
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4573
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 3004
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2832
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2405
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 796
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 796
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 6104
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH atdv-202-amesos-enable-epetra-off
TRILINOS_SOURCE_REPO https://github.com/bartlettroscoe/Trilinos
TRILINOS_SOURCE_SHA ce9eeeb
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 441eccf


CDash Test Results for PR# 6104.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@bartlettroscoe
Copy link
Member Author

@rppawlo and @jmgate, can you please approve this when you have time?

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 36fc3e6 into trilinos:develop Oct 16, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 6104: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Oct 16, 2019
@bartlettroscoe bartlettroscoe mentioned this pull request Oct 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rppawlo rppawlo rppawlo approved these changes

@jmgate jmgate Awaiting requested review from jmgate

@fryeguy52 fryeguy52 Awaiting requested review from fryeguy52

Assignees
No one assigned
Labels
ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: EMPIRE All issues that most directly target the ATDM EMPIRE code pkg: Amesos2 type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartlettroscoe @trilinos-autotester @rppawlo @mhoemmen