Intrepid HGRAD Bases: avoid potential buffer overrun, eliminate extraneous console output, and avoid exceptions thrown when run in Debug mode #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 26, 2016 12:27
…ner reference that would cause an exception to be thrown when run in Debug mode.
…o run with a polynomial order of 0 results in a buffer overrun during initializeTags()--a silent, subtle failure.
…gles is not linearly independent for warp blend points. The change brings the strategy for setting up the basis for triangles in line with that already used for tetrahedra.
|
Closing this so that I can recreate on a different branch—sorry, this is my first pull request! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for HGRAD bases on hexahedra and triangles.